From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FE08E81815 for ; Tue, 26 Sep 2023 03:16:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229772AbjIZDQI (ORCPT ); Mon, 25 Sep 2023 23:16:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbjIZDQI (ORCPT ); Mon, 25 Sep 2023 23:16:08 -0400 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E6F0A3; Mon, 25 Sep 2023 20:16:00 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qkyXf-000cC3-99; Tue, 26 Sep 2023 11:15:20 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Tue, 26 Sep 2023 11:15:22 +0800 Date: Tue, 26 Sep 2023 11:15:22 +0800 From: Herbert Xu To: Alexey Romanov Cc: "narmstrong@baylibre.com" , "neil.armstrong@linaro.org" , "olivia@selenic.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "conor@kernel.org" , "khilman@baylibre.com" , "jbrunet@baylibre.com" , "martin.blumenstingl@googlemail.com" , "f.fainelli@gmail.com" , "hkallweit1@gmail.com" , "lists@kaiser.cx" , "linux-arm-kernel@lists.infradead.org" , "linux-amlogic@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-crypto@vger.kernel.org" , kernel Subject: Re: [PATCH v3 1/3] drivers: rng: meson: add support for S4 Message-ID: References: <20230911101129.10604-1-avromanov@salutedevices.com> <20230911101129.10604-2-avromanov@salutedevices.com> <20230922081514.p7patdvkp4mujk6k@cab-wsm-0029881.sigma.sbrf.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230922081514.p7patdvkp4mujk6k@cab-wsm-0029881.sigma.sbrf.ru> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Sep 22, 2023 at 08:15:27AM +0000, Alexey Romanov wrote: > > Are you suggesting remove meson_rng_priv and putting a pointer to read > function in meson_rng_data? I just thought it was weird that you assign meson_rng_data->priv and then never use it anywhere else in the driver. Did I miss something? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt