From: Wang Jinchao <wangjinchao@xfusion.com>
To: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] padata: Fix the UAF issue related to parallel_data
Date: Sat, 7 Oct 2023 12:01:48 +0800 [thread overview]
Message-ID: <ZSDYLKRcGFp2Kcxe@fedora> (raw)
In-Reply-To: <paajlxnnp6isq435i7w2onndi56xpwahq6tl6hbjwqdhta375l@kqgpf5nkcsog>
On Wed, Oct 04, 2023 at 03:07:10PM -0400, Daniel Jordan wrote:
> On Wed, Oct 04, 2023 at 10:54:29AM -0400, Daniel Jordan wrote:
> > On Thu, Sep 28, 2023 at 08:38:53AM +0800, Wang Jinchao wrote:
...
> > This could use a Fixes tag. From Nicolai's patch[0] we agreed on
> >
> > Fixes: 07928d9bfc81 ("padata: Remove broken queue flushing")
> >
> > With that,
> >
> > Acked-by: Daniel Jordan <daniel.m.jordan@oracle.com>
> >
> > Thanks!
> >
...
>
> Oh, I should've also said please move the declaration of pd to the top
> of the function like scripts/checkpatch.pl suggests.
>
> > > + if (refcount_dec_and_test(&pd->refcnt))
> > > + padata_free_pd(pd);
> > > mutex_unlock(&ps->pinst->lock);
> > >
> > > kfree(ps);
> > > --
> > > 2.40.0
> > >
Thanks for suggestion, both were updated in V3.
V3: https://lore.kernel.org/all/ZSDWAcUxXcwD4YUZ@fedora/
prev parent reply other threads:[~2023-10-07 4:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 0:38 [PATCH v2] padata: Fix the UAF issue related to parallel_data Wang Jinchao
2023-10-04 14:54 ` Daniel Jordan
2023-10-04 19:07 ` Daniel Jordan
2023-10-07 4:01 ` Wang Jinchao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSDYLKRcGFp2Kcxe@fedora \
--to=wangjinchao@xfusion.com \
--cc=daniel.m.jordan@oracle.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).