From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75DB9E9413F for ; Sat, 7 Oct 2023 04:02:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232681AbjJGECD (ORCPT ); Sat, 7 Oct 2023 00:02:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbjJGECC (ORCPT ); Sat, 7 Oct 2023 00:02:02 -0400 Received: from wxsgout04.xfusion.com (wxsgout03.xfusion.com [36.139.52.80]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 189E6BD; Fri, 6 Oct 2023 21:02:00 -0700 (PDT) Received: from wuxshcsitd00600.xfusion.com (unknown [10.32.133.213]) by wxsgout04.xfusion.com (SkyGuard) with ESMTPS id 4S2WlG3PyszB0Y9d; Sat, 7 Oct 2023 11:59:38 +0800 (CST) Received: from localhost (10.82.147.3) by wuxshcsitd00600.xfusion.com (10.32.133.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sat, 7 Oct 2023 12:01:48 +0800 Date: Sat, 7 Oct 2023 12:01:48 +0800 From: Wang Jinchao To: Daniel Jordan CC: Steffen Klassert , , Subject: Re: [PATCH v2] padata: Fix the UAF issue related to parallel_data Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.82.147.3] X-ClientProxiedBy: wuxshcsitd00601.xfusion.com (10.32.135.241) To wuxshcsitd00600.xfusion.com (10.32.133.213) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Oct 04, 2023 at 03:07:10PM -0400, Daniel Jordan wrote: > On Wed, Oct 04, 2023 at 10:54:29AM -0400, Daniel Jordan wrote: > > On Thu, Sep 28, 2023 at 08:38:53AM +0800, Wang Jinchao wrote: ... > > This could use a Fixes tag. From Nicolai's patch[0] we agreed on > > > > Fixes: 07928d9bfc81 ("padata: Remove broken queue flushing") > > > > With that, > > > > Acked-by: Daniel Jordan > > > > Thanks! > > ... > > Oh, I should've also said please move the declaration of pd to the top > of the function like scripts/checkpatch.pl suggests. > > > > + if (refcount_dec_and_test(&pd->refcnt)) > > > + padata_free_pd(pd); > > > mutex_unlock(&ps->pinst->lock); > > > > > > kfree(ps); > > > -- > > > 2.40.0 > > > Thanks for suggestion, both were updated in V3. V3: https://lore.kernel.org/all/ZSDWAcUxXcwD4YUZ@fedora/