From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41765CDB47E for ; Fri, 13 Oct 2023 10:13:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230380AbjJMKNX (ORCPT ); Fri, 13 Oct 2023 06:13:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230179AbjJMKNW (ORCPT ); Fri, 13 Oct 2023 06:13:22 -0400 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1A71A9 for ; Fri, 13 Oct 2023 03:13:19 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qrFAQ-006iwe-L0; Fri, 13 Oct 2023 18:13:15 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 13 Oct 2023 18:13:19 +0800 Date: Fri, 13 Oct 2023 18:13:19 +0800 From: Herbert Xu To: Eric Biggers Cc: linux-crypto@vger.kernel.org Subject: Re: [PATCH] crypto: xts - use 'spawn' for underlying single-block cipher Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231009023116.266210-1-ebiggers@kernel.org> X-Newsgroups: apana.lists.os.linux.cryptoapi Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Eric Biggers wrote: > > static int xts_create(struct crypto_template *tmpl, struct rtattr **tb) > { > struct skcipher_instance *inst; > struct xts_instance_ctx *ctx; > struct skcipher_alg *alg; > const char *cipher_name; > + char name[CRYPTO_MAX_ALG_NAME]; Please keep the line sorting from longest to shortest. I'll fix this one by hand so this is just for future reference. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt