From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79260C001DF for ; Fri, 20 Oct 2023 05:54:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233509AbjJTFyx (ORCPT ); Fri, 20 Oct 2023 01:54:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235631AbjJTFyv (ORCPT ); Fri, 20 Oct 2023 01:54:51 -0400 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F3FED65; Thu, 19 Oct 2023 22:54:48 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qtiSm-0097bb-Am; Fri, 20 Oct 2023 13:54:25 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 20 Oct 2023 13:54:29 +0800 Date: Fri, 20 Oct 2023 13:54:29 +0800 From: Herbert Xu To: Dimitri John Ledkov Cc: David Howells , "David S. Miller" , Maxime Coquelin , Alexandre Torgue , Luis Chamberlain , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-modules@vger.kernel.org Subject: Re: [PATCH] crypto: pkcs7: remove sha1 support Message-ID: References: <20231010212240.61637-1-dimitri.ledkov@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231010212240.61637-1-dimitri.ledkov@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Oct 10, 2023 at 10:22:38PM +0100, Dimitri John Ledkov wrote: > Removes support for sha1 signed kernel modules, importing sha1 signed > x.509 certificates. > > rsa-pkcs1pad keeps sha1 padding support, which seems to be used by > virtio driver. > > sha1 remains available as there are many drivers and subsystems using > it. Note only hmac(sha1) with secret keys remains cryptographically > secure. > > In the kernel there are filesystems, IMA, tpm/pcr that appear to be > using sha1. Maybe they can all start to be slowly upgraded to > something else i.e. blake3, ParallelHash, SHAKE256 as needed. > > Signed-off-by: Dimitri John Ledkov > --- > crypto/asymmetric_keys/mscode_parser.c | 3 - > crypto/asymmetric_keys/pkcs7_parser.c | 4 -- > crypto/asymmetric_keys/public_key.c | 3 +- > crypto/asymmetric_keys/signature.c | 2 +- > crypto/asymmetric_keys/x509_cert_parser.c | 8 --- > crypto/testmgr.h | 80 ----------------------- > include/linux/oid_registry.h | 4 -- > kernel/module/Kconfig | 5 -- > 8 files changed, 2 insertions(+), 107 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt