From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67757C00A8F for ; Tue, 24 Oct 2023 04:11:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231820AbjJXELq (ORCPT ); Tue, 24 Oct 2023 00:11:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232099AbjJXELo (ORCPT ); Tue, 24 Oct 2023 00:11:44 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00841F9 for ; Mon, 23 Oct 2023 21:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698120658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=caernG/TBksc+n5E7N1NZ2+jzhSZWw1AOXk83LPtKCQ=; b=QwYl5BWHnX4+xVhzlGdoxyyfDOF0x0b2+nTi9ISlmeFw976iWxatFsBw+uLxUQaa8TyrwG GXRRsy6taa5NHdWE/t/GEM9SwP4l4fV8tKq1VC2vdgKfBsaBdrJrP49j/fCfEDZQ/gBogi AWjEJYFO2ti8Vm+ya1qCJ3BLNUVg89Q= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-133-x4-R9quaNDOSNfhk7mjDJQ-1; Tue, 24 Oct 2023 00:10:56 -0400 X-MC-Unique: x4-R9quaNDOSNfhk7mjDJQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0393D185A790; Tue, 24 Oct 2023 04:10:55 +0000 (UTC) Received: from localhost (unknown [10.72.112.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A05BD40C6F79; Tue, 24 Oct 2023 04:10:53 +0000 (UTC) Date: Tue, 24 Oct 2023 12:10:51 +0800 From: Baoquan He To: Arnd Bergmann Cc: Vivek Goyal , Andrew Morton , Herbert Xu , "David S . Miller" , linux-crypto@vger.kernel.org, Arnd Bergmann , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Eric DeVolder , "Peter Zijlstra (Intel)" , Ard Biesheuvel , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, Hari Bathini , Costa Shulyupin Subject: Re: [PATCH 2/2] kexec: select CRYPTO from KEXEC_FILE instead of depending on it Message-ID: References: <20231023110308.1202042-1-arnd@kernel.org> <20231023110308.1202042-2-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 10/24/23 at 11:55am, Baoquan He wrote: > On 10/23/23 at 01:01pm, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > All other users of crypto code use 'select' instead of 'depends on', > > so do the same thing with KEXEC_FILE for consistency. > > > > In practice this makes very little difference as kernels with kexec > > support are very likely to also include some other feature that already > > selects both crypto and crypto_sha256, but being consistent here helps > > for usability as well as to avoid potential circular dependencies. > > > > This reverts the dependency back to what it was originally before commit > > 74ca317c26a3f ("kexec: create a new config option CONFIG_KEXEC_FILE for > > new syscall"), which changed changed it with the comment "This should > ~~~~~~~~~~~~~~ typo > > be safer as "select" is not recursive", but that appears to have been > > done in error, as "select" is indeed recursive, and there are no other > > dependencies that prevent CRYPTO_SHA256 from being selected here. > > > > Fixes: 74ca317c26a3f ("kexec: create a new config option CONFIG_KEXEC_FILE for new syscall") > > Cc: Herbert Xu > > Cc: "David S. Miller" > > Cc: linux-crypto@vger.kernel.org > > Signed-off-by: Arnd Bergmann > > --- > > kernel/Kconfig.kexec | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > LGTM, > > Acked-by: Baoquan He Sorry, the patch 1/2 is not sent to me and kexec mailing list, so I didn't get the intention of the entire patchset. I need hold the ack until I read the patch 1. I have some concerns about patch 1 if I didn't misunderstand it. Will come back later when patch 1 reviewing is finished. > > > > > diff --git a/kernel/Kconfig.kexec b/kernel/Kconfig.kexec > > index bfc636d64ff2b..51f719af10e79 100644 > > --- a/kernel/Kconfig.kexec > > +++ b/kernel/Kconfig.kexec > > @@ -36,7 +36,8 @@ config KEXEC > > config KEXEC_FILE > > bool "Enable kexec file based system call" > > depends on ARCH_SUPPORTS_KEXEC_FILE > > - depends on CRYPTO_SHA256=y || !ARCH_SUPPORTS_KEXEC_PURGATORY > > + select CRYPTO > > + select CRYPTO_SHA256 > > select KEXEC_CORE > > help > > This is new version of kexec system call. This system call is > > -- > > 2.39.2 > > >