From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30785C4332F for ; Thu, 2 Nov 2023 04:31:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348489AbjKBEbv (ORCPT ); Thu, 2 Nov 2023 00:31:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348480AbjKBEbu (ORCPT ); Thu, 2 Nov 2023 00:31:50 -0400 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 840C2189; Wed, 1 Nov 2023 21:31:16 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qyPLp-00DS8w-RW; Thu, 02 Nov 2023 12:30:38 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Thu, 02 Nov 2023 12:30:44 +0800 Date: Thu, 2 Nov 2023 12:30:44 +0800 From: Herbert Xu To: Eric Biggers Cc: Yuran Pereira , linux-crypto@vger.kernel.org, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH 0/7] crypto: Proper Initialization of `struct skcipher_walk` in x86 Glue Files Message-ID: References: <20231102042043.GD1498@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231102042043.GD1498@sol.localdomain> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Nov 01, 2023 at 09:20:43PM -0700, Eric Biggers wrote: > > Updating all callers of skcipher_walk_virt() seems like the wrong approach. > Shouldn't skcipher_walk_virt() be fixed to initialize the flags to 0 instead? The bits of the flags that are used are initialised in skcipher_walk_next. > Also, does this fix affect any behavior, or is it just to fix a KMSAN warning? > It needs to be fixed either way, but it's helpful to understand the effect of > the fix so that people can decide whether it needs to be backported or not. Does this actually trigger a KMSAN warning? If so I'd like to see it. If it's just a static analyser then I'm not applying this. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt