From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED18F1FCA; Fri, 1 Dec 2023 01:34:17 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1r8zuK-005gqn-NS; Fri, 01 Dec 2023 17:34:01 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 01 Dec 2023 17:34:09 +0800 Date: Fri, 1 Dec 2023 17:34:09 +0800 From: Herbert Xu To: LeoLiu-oc Cc: olivia@selenic.com, martin@kaiser.cx, jiajie.ho@starfivetech.com, jenny.zhang@starfivetech.com, mmyangfl@gmail.com, robh@kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, x86@vger.kernel.org, CobeChen@zhaoxin.com, TonyWWang@zhaoxin.com, YunShen@zhaoxin.com, LeoLiu@zhaoxin.com Subject: Re: [PATCH v2] hwrng: add Zhaoxin rng driver base on rep_xstore instruction Message-ID: References: <20231107070900.496827-1-LeoLiu-oc@zhaoxin.com> <20231121032939.610048-1-LeoLiu-oc@zhaoxin.com> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231121032939.610048-1-LeoLiu-oc@zhaoxin.com> On Tue, Nov 21, 2023 at 11:29:39AM +0800, LeoLiu-oc wrote: > > +static const struct x86_cpu_id via_rng_cpu_ids[] = { > + X86_MATCH_VENDOR_FAM_FEATURE(CENTAUR, 6, X86_FEATURE_XSTORE, NULL), > + {} > +}; > +MODULE_DEVICE_TABLE(x86cpu, via_rng_cpu_ids); Rather than moving the whole thing, just add this near the start of the file: static const struct x86_cpu_id via_rng_cpu_ids[]; Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt