From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 709F41704; Fri, 1 Dec 2023 03:41:12 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1r91tG-005jtE-EO; Fri, 01 Dec 2023 19:41:03 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 01 Dec 2023 19:41:11 +0800 Date: Fri, 1 Dec 2023 19:41:11 +0800 From: Herbert Xu To: Edward Adam Davis Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, olivia@selenic.com, syzbot+c52ab18308964d248092@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com Subject: Re: [PATCH] hwrng: core - fix task hung in hwrng_fillfn Message-ID: References: Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Dec 01, 2023 at 07:37:39PM +0800, Edward Adam Davis wrote: > > Reduce the scope of critical zone protection. > The original critical zone contains a too large range, especially like > copy_to_user() should not be included in the critical zone. Which part in particular is taking 143 seconds? The buffer is only 128 bytes long. Why is a 128-byte copy taking 143 seconds, even with a page fault? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt