From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wxsgout04.xfusion.com (wxsgout04.xfusion.com [36.139.87.180]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A4B3AB; Tue, 12 Dec 2023 19:01:12 -0800 (PST) Received: from wuxshcsitd00600.xfusion.com (unknown [10.32.133.213]) by wxsgout04.xfusion.com (SkyGuard) with ESMTPS id 4SqgBq5S1sz9yxwg; Wed, 13 Dec 2023 10:57:39 +0800 (CST) Received: from localhost (10.82.147.3) by wuxshcsitd00600.xfusion.com (10.32.133.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 13 Dec 2023 11:01:07 +0800 Date: Wed, 13 Dec 2023 11:01:06 +0800 From: Wang Jinchao To: Tim Chen CC: Herbert Xu , "David S. Miller" , Steffen Klassert , Daniel Jordan , , , Subject: Re: [PATCH] crypto: tcrypt - add script tcrypt_speed_compare.py Message-ID: References: <202312101758+0800-wangjinchao@xfusion.com> <118d0b232f7daffc56db814f90dba7bad266c5ab.camel@linux.intel.com> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <118d0b232f7daffc56db814f90dba7bad266c5ab.camel@linux.intel.com> X-ClientProxiedBy: wuxshcsitd00603.xfusion.com (10.32.134.231) To wuxshcsitd00600.xfusion.com (10.32.133.213) On Tue, Dec 12, 2023 at 01:56:56PM -0800, Tim Chen wrote: > On Sun, 2023-12-10 at 18:19 +0800, WangJinchao wrote: > > Create a script for comparing tcrypt speed test logs. > > The script will systematically analyze differences item > > by item and provide a summary (average). > > This tool is useful for evaluating the stability of > > cryptographic module algorithms and assisting with > > performance optimization. > > I have found that for such comparison, the stability is > dependent on whether we allow the frequency to > float or we pin the frequency. So in the past when > I use tcrypt, sometimes I have > to pin the frequency of CPU for stable results. > > One suggestion I have is for for you to also dump the > frequency governor and P-state info so we know > for the runs being compared, whether they are running > with the same CPU frequency. > > Tim > Thank you for the feedback. This information is valuable for stability testing and performance optimization. However, I am uncertain about how to dump P-state information, or I believe that the script is unable to do so. The reasons are as follows: 1. The primary purpose of this script is to compare tcrypt logs, and it is executed after the completion of the tcrypt tests. Consequently, it cannot dump P-state information during tcrypt's runtime. 2. In virtualized environments, there is no available information in the `/sys/devices/system/cpu/cpufreq` directory pertaining to P-state details. Am I correct in my understanding? I am considering documenting your suggestion in the script's comments. What are your thoughts? >