Re: [PATCH 2/2] crypto: virtio-crypto: Fix gcc check warnings

Herbert Xu
2023-12-22T03:33:52Z

On Mon, Dec 11, 2023 at 07:42:16PM +0800, Gonglei wrote:
>
> static inline int virtio_crypto_get_current_node(void)
> {
> - int cpu, node;
> + int node;
>
> - cpu = get_cpu();
> - node = topology_physical_package_id(cpu);
> + node = topology_physical_package_id(get_cpu());

This looks like a bogus warning. I think we should do something
like this instead:

diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
index ae81a7191c1c..0cb43986061b 100644
--- a/arch/x86/include/asm/processor.h
+++ b/arch/x86/include/asm/processor.h
@@ -191,7 +191,7 @@ DECLARE_PER_CPU_READ_MOSTLY(struct cpuinfo_x86, cpu_info);
#define cpu_data(cpu) per_cpu(cpu_info, cpu)
#else
#define cpu_info boot_cpu_data
-#define cpu_data(cpu) boot_cpu_data
+#define cpu_data(cpu) ((void)cpu, boot_cpu_data)
#endif

extern const struct seq_operations cpuinfo_op;

Please send this patch to the x86 people.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt