From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ovidiu Panait <ovidiu.panait.oss@gmail.com>,
linux-crypto@vger.kernel.org, davem@davemloft.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] crypto: img-hash - use API helpers to setup fallback request
Date: Wed, 16 Apr 2025 11:55:48 +0200 [thread overview]
Message-ID: <Z_9-pJ_lXA3AzjGC@Red> (raw)
In-Reply-To: <Z_9ie2KwYhCaK_mB@gondor.apana.org.au>
Le Wed, Apr 16, 2025 at 03:55:39PM +0800, Herbert Xu a écrit :
> On Mon, Apr 07, 2025 at 03:36:01PM +0300, Ovidiu Panait wrote:
> > Rather than setting up the fallback request by hand, use
> > ahash_request_set_callback() and ahash_request_set_crypt() API helpers
> > to properly setup the new request.
> >
> > This also ensures that the completion callback is properly passed down
> > to the fallback algorithm, which avoids a crash with async fallbacks.
> >
> > Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
> > ---
> > drivers/crypto/img-hash.c | 41 ++++++++++++++++++++++-----------------
> > 1 file changed, 23 insertions(+), 18 deletions(-)
>
> Patches 1-2,4 applied. Thanks.
You can merge sun8i-ss patch, it is ok.
Could you add my tested-by on rk3328 patch also ?
Thanks
prev parent reply other threads:[~2025-04-16 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 12:36 [PATCH 1/4] crypto: img-hash - use API helpers to setup fallback request Ovidiu Panait
2025-04-07 12:36 ` [PATCH 2/4] crypto: rk3288 " Ovidiu Panait
2025-04-07 12:36 ` [PATCH 3/4] crypto: sun8i-ss " Ovidiu Panait
2025-04-14 11:56 ` Corentin Labbe
2025-04-14 14:31 ` Corentin Labbe
2025-04-17 7:16 ` Herbert Xu
2025-04-07 12:36 ` [PATCH 4/4] crypto: tegra " Ovidiu Panait
2025-04-16 7:55 ` [PATCH 1/4] crypto: img-hash " Herbert Xu
2025-04-16 9:55 ` Corentin Labbe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_9-pJ_lXA3AzjGC@Red \
--to=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ovidiu.panait.oss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).