From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: Xi Ruoyao <xry111@xry111.site>, WANG Xuerui <kernel@xen0n.name>,
linux-crypto@vger.kernel.org, loongarch@lists.linux.dev,
Jinyang He <hejinyang@loongson.cn>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v3 1/3] LoongArch: vDSO: Wire up getrandom() vDSO implementation
Date: Mon, 19 Aug 2024 13:03:17 +0000 [thread overview]
Message-ID: <ZsNClVFzfi3djXDz@zx2c4.com> (raw)
In-Reply-To: <CAAhV-H7TKg98QXtrv9UmzZd9O=pxERvzCsz83Y+m+kf0zbeCkA@mail.gmail.com>
> > The compiler (GCC 14.2) calls memset() for initializing a "large" struct
> > in a cold path of the generic vDSO getrandom() code. There seems no way
> > to prevent it from calling memset(), and it's a cold path so the
> > performance does not matter, so just provide a naive memset()
> > implementation for vDSO.
> Why x86 doesn't need to provide a naive memset()?
It looks like others are running into this when porting to ppc and
arm64, so I'll probably refactor the code to avoid needing it in the
first place. I'll chime in here when that's done.
Jason
next prev parent reply other threads:[~2024-08-19 13:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 11:07 Xi Ruoyao
2024-08-16 11:07 ` [PATCH v3 1/3] LoongArch: vDSO: Wire up getrandom() vDSO implementation Xi Ruoyao
2024-08-19 12:41 ` Huacai Chen
2024-08-19 13:03 ` Jason A. Donenfeld [this message]
2024-08-19 15:36 ` Xi Ruoyao
2024-08-20 0:50 ` Jinyang He
2024-08-20 1:09 ` Xi Ruoyao
2024-08-20 2:03 ` Jinyang He
2024-08-16 11:07 ` [PATCH v3 2/3] LoongArch: Perform alternative runtime patching on vDSO Xi Ruoyao
2024-08-16 11:07 ` [PATCH v3 3/3] LoongArch: vDSO: Add LSX implementation of vDSO getrandom() Xi Ruoyao
2024-08-19 12:40 ` Huacai Chen
2024-08-19 13:01 ` Re: Jason A. Donenfeld
2024-08-19 15:22 ` Re: Xi Ruoyao
2024-08-19 15:54 ` Re: Xi Ruoyao
2024-08-19 15:22 ` Re: Xi Ruoyao
2024-08-27 9:45 ` Re: Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsNClVFzfi3djXDz@zx2c4.com \
--to=jason@zx2c4.com \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=hejinyang@loongson.cn \
--cc=kernel@xen0n.name \
--cc=linux-crypto@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=xry111@xry111.site \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).