From: Herbert Xu <herbert@gondor.apana.org.au>
To: Fangrui Song <maskray@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-crypto@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] crypto: x86/sha256: Add parentheses around macros' single arguments
Date: Sat, 24 Aug 2024 21:49:41 +0800 [thread overview]
Message-ID: <Zsnk9cxUbjL5H_bI@gondor.apana.org.au> (raw)
In-Reply-To: <20240814044802.1743286-1-maskray@google.com>
On Tue, Aug 13, 2024 at 09:48:02PM -0700, Fangrui Song wrote:
> The macros FOUR_ROUNDS_AND_SCHED and DO_4ROUNDS rely on an
> unexpected/undocumented behavior of the GNU assembler, which might
> change in the future
> (https://sourceware.org/bugzilla/show_bug.cgi?id=32073).
>
> M (1) (2) // 1 arg !? Future: 2 args
> M 1 + 2 // 1 arg !? Future: 3 args
>
> M 1 2 // 2 args
>
> Add parentheses around the single arguments to support future GNU
> assembler and LLVM integrated assembler (when the IsOperator hack from
> the following link is dropped).
>
> Link: https://github.com/llvm/llvm-project/commit/055006475e22014b28a070db1bff41ca15f322f0
> Signed-off-by: Fangrui Song <maskray@google.com>
> ---
> arch/x86/crypto/sha256-avx2-asm.S | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2024-08-24 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 4:48 [PATCH] crypto: x86/sha256: Add parentheses around macros' single arguments Fangrui Song
2024-08-14 6:14 ` Jan Beulich
2024-08-24 13:49 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zsnk9cxUbjL5H_bI@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=jbeulich@suse.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maskray@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox