From: Herbert Xu <herbert@gondor.apana.org.au>
To: "linwenkai (C)" <linwenkai6@hisilicon.com>
Cc: Chenghai Huang <huangchenghai2@huawei.com>,
davem@davemloft.net, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, liulongfang@huawei.com,
qianweili@huawei.com, wangzhou1@hisilicon.com
Subject: Re: [PATCH v3 2/2] crypto: hisilicon/sec2 - fix for aead invalid authsize
Date: Fri, 15 Nov 2024 10:09:28 +0800 [thread overview]
Message-ID: <ZzatWBNAyjsuaRP6@gondor.apana.org.au> (raw)
In-Reply-To: <b67cecd0-e50c-40bd-99b7-b85482e55696@hisilicon.com>
On Thu, Nov 14, 2024 at 08:47:11PM +0800, linwenkai (C) wrote:
>
> I have found another setup for fallback in the sec_aead_param_check
> function, so I need to fix it right too.
So you want to determine whether to use the fallback based on
the parameters of the request. In that case I think you should
create a new fallback field in the request context. Set its
initial value to that of the tfm context fallback variable, and
then modify it based on the request parameters.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2024-11-15 2:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-02 2:55 [PATCH v3 0/2] crypto: hisilicon - fix the authsize and icv problems of aead in sec Chenghai Huang
2024-11-02 2:55 ` [PATCH v3 1/2] crypto: hisilicon/sec2 - fix for aead icv error Chenghai Huang
2024-11-02 2:55 ` [PATCH v3 2/2] crypto: hisilicon/sec2 - fix for aead invalid authsize Chenghai Huang
2024-11-10 3:36 ` Herbert Xu
2024-11-12 2:46 ` linwenkai (C)
2024-11-14 12:47 ` linwenkai (C)
2024-11-15 2:09 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzatWBNAyjsuaRP6@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=huangchenghai2@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linwenkai6@hisilicon.com \
--cc=liulongfang@huawei.com \
--cc=qianweili@huawei.com \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox