From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA5B7C7EE2E for ; Sat, 10 Jun 2023 03:21:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231279AbjFJDU7 (ORCPT ); Fri, 9 Jun 2023 23:20:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjFJDU6 (ORCPT ); Fri, 9 Jun 2023 23:20:58 -0400 Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54B61E1; Fri, 9 Jun 2023 20:20:55 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=xianting.tian@linux.alibaba.com;NM=1;PH=DS;RN=17;SR=0;TI=SMTPD_---0VkjuBza_1686367249; Received: from 30.13.188.136(mailfrom:xianting.tian@linux.alibaba.com fp:SMTPD_---0VkjuBza_1686367249) by smtp.aliyun-inc.com; Sat, 10 Jun 2023 11:20:51 +0800 Message-ID: Date: Sat, 10 Jun 2023 11:20:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/3] virtio-crypto: fixup potential cpu stall when free unused bufs To: "Michael S. Tsirkin" Cc: arei.gonglei@huawei.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, herbert@gondor.apana.org.au, davem@davemloft.net, amit@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Xianting Tian References: <20230609131817.712867-1-xianting.tian@linux.alibaba.com> <20230609131817.712867-2-xianting.tian@linux.alibaba.com> <20230609115617-mutt-send-email-mst@kernel.org> From: Xianting Tian In-Reply-To: <20230609115617-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org 在 2023/6/9 下午11:57, Michael S. Tsirkin 写道: > On Fri, Jun 09, 2023 at 09:18:15PM +0800, Xianting Tian wrote: >> From: Xianting Tian >> >> Cpu stall issue may happen if device is configured with multi queues >> and large queue depth, so fix it. > What does "may happen" imply exactly? > was this observed? I didn't met such issue, this patch set just a theoretical fix. > >> Signed-off-by: Xianting Tian >> --- >> drivers/crypto/virtio/virtio_crypto_core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/crypto/virtio/virtio_crypto_core.c b/drivers/crypto/virtio/virtio_crypto_core.c >> index 1198bd306365..94849fa3bd74 100644 >> --- a/drivers/crypto/virtio/virtio_crypto_core.c >> +++ b/drivers/crypto/virtio/virtio_crypto_core.c >> @@ -480,6 +480,7 @@ static void virtcrypto_free_unused_reqs(struct virtio_crypto *vcrypto) >> kfree(vc_req->req_data); >> kfree(vc_req->sgs); >> } >> + cond_resched(); >> } >> } >> >> -- >> 2.17.1