From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B32FA26ED46 for ; Mon, 15 Jun 2026 06:46:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781505988; cv=none; b=XUQSc4JHbZIAllPr2bs0Ko2kqkduIfukLCtTZfIadsP5PncSQ77zzDRViugBkdCsn8ylxpDRQsKRNElhz2H6D0tu7blvj0Pfs9f2N1Vdy9RnYRzNdqJTa0XtSILu6CBiY1bb/fsWbpD5jTX/JNyh/v2Ay3dQTtlVMrVI+EQuWSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781505988; c=relaxed/simple; bh=V0lJACwgXhHJPicXPFvDru50IffzdKNMnTaHADa8x+M=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=ba0LCDyhGuP6nMOV+Wy2hAmhsp7vI6BN/6MaYC1se16qqWcfpWn8yYlO5h0fdaf++Qg8vYeIdAd7aQNFYmhYvtQsQwNKQYrjI+YMrTrB7ukMYQVZ6UzPz6XFDCoCnlPNeTLjrx/NYrPnFxcC4h5Gd6DA+aB4L+v2aLXEbmxbTF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=YRcccamq; arc=none smtp.client-ip=91.218.175.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="YRcccamq" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1781505983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kiNn3K9N6RX2fnyMI3v5LyzAfNqLkHIr+etJKHcVcyA=; b=YRcccamqVeyplgLY6g72+XwGxO+KOB0ikzq1UXRC7/p4lfOmQX0k3VjQCMLC0GlIOpHmOJ rTedpNt1ol98SksZxhCW/2LPFOdxJEuNfYs5Eoy04o1tH6u5LPsdD1Kuke0NCUTgrNQBGE oz7flLfHA9VwpuU/4BfEr4brsMrHGdw= Date: Sun, 14 Jun 2026 23:46:16 -0700 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v3 2/4] KVM: selftests: Verify SNP VMs are rejected from migration and mirroring X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Atish Patra To: Sean Christopherson , Paolo Bonzini , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Tom Lendacky , Peter Gonda , Brijesh Singh , Youngjae Lee , Ashish Kalra , Michael Roth , John Allen , Herbert Xu Cc: clm@meta.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, stable@vger.kernel.org, Atish Patra References: <20260602-sev_snp_fixes-v3-0-585e4783a42f@meta.com> <20260602-sev_snp_fixes-v3-2-585e4783a42f@meta.com> Content-Language: en-US In-Reply-To: <20260602-sev_snp_fixes-v3-2-585e4783a42f@meta.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 6/2/26 3:11 PM, Atish Patra wrote: > From: Atish Patra > > Migration and mirroring of SEV-SNP VMs are not supported yet. > > Add two selftests that verify KVM rejects intra-host migration and > mirroring when the source VM is an SNP VM, so the restriction stays enforced > until proper SNP state transfer is implemented. > > Signed-off-by: Atish Patra > --- > .../testing/selftests/kvm/x86/sev_migrate_tests.c | 47 ++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > > diff --git a/tools/testing/selftests/kvm/x86/sev_migrate_tests.c b/tools/testing/selftests/kvm/x86/sev_migrate_tests.c > index 6b0928e69051..acef6ab26d3d 100644 > --- a/tools/testing/selftests/kvm/x86/sev_migrate_tests.c > +++ b/tools/testing/selftests/kvm/x86/sev_migrate_tests.c > @@ -313,6 +313,49 @@ static void test_sev_mirror_parameters(void) > kvm_vm_free(vm_no_vcpu); > } > > +static void test_sev_snp_migrate_reject(void) > +{ > + struct kvm_vm *src_vm, *dst_vm; > + int ret; > + > + src_vm = vm_create_barebones_type(KVM_X86_SNP_VM); > + snp_vm_init(src_vm); > + __vm_vcpu_add(src_vm, 0); > + vm_sev_launch(src_vm, snp_default_policy(), NULL); > + > + dst_vm = vm_create_barebones_type(KVM_X86_SNP_VM); > + __vm_vcpu_add(dst_vm, 0); > + > + ret = __sev_migrate_from(dst_vm, src_vm); > + TEST_ASSERT(ret == -1 && errno == EINVAL, > + "SNP VM migration should be rejected. ret: %d, errno: %d", > + ret, errno); > + > + kvm_vm_free(src_vm); > + kvm_vm_free(dst_vm); > +} > + > +static void test_sev_snp_mirror_reject(void) > +{ > + struct kvm_vm *src_vm, *dst_vm; > + int ret; > + > + src_vm = vm_create_barebones_type(KVM_X86_SNP_VM); > + snp_vm_init(src_vm); > + __vm_vcpu_add(src_vm, 0); > + vm_sev_launch(src_vm, snp_default_policy(), NULL); > + > + dst_vm = aux_vm_create(false); > + > + ret = __sev_mirror_create(dst_vm, src_vm); > + TEST_ASSERT(ret == -1 && errno == EINVAL, > + "SNP VM mirroring should be rejected. ret: %d, errno: %d", > + ret, errno); > + > + kvm_vm_free(src_vm); > + kvm_vm_free(dst_vm); > +} > + > static void test_sev_move_copy(void) > { > struct kvm_vm *dst_vm, *dst2_vm, *dst3_vm, *sev_vm, *mirror_vm, > @@ -384,12 +427,16 @@ int main(int argc, char *argv[]) > test_sev_migrate_parameters(); > if (kvm_has_cap(KVM_CAP_VM_COPY_ENC_CONTEXT_FROM)) > test_sev_move_copy(); > + if (kvm_cpu_has(X86_FEATURE_SEV_SNP)) > + test_sev_snp_migrate_reject(); > } > if (kvm_has_cap(KVM_CAP_VM_COPY_ENC_CONTEXT_FROM)) { > test_sev_mirror(/* es= */ false); > if (have_sev_es) > test_sev_mirror(/* es= */ true); > test_sev_mirror_parameters(); > + if (kvm_cpu_has(X86_FEATURE_SEV_SNP)) > + test_sev_snp_mirror_reject(); > } > return 0; > } > gentle ping for any feedback on this patch ?