Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Rosen Penev <rosenp@gmail.com>,
	linux-crypto@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Vladimir Zapolskiy <vz@mleia.com>,
	"David S. Miller" <davem@davemloft.net>,
	"open list:SAMSUNG S5P Security SubSystem (SSS) DRIVER"
	<linux-samsung-soc@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: s5p-sss: pass s5p_aes_dev to irq handler
Date: Tue, 11 Aug 2026 07:43:18 +0200	[thread overview]
Message-ID: <a736b169-8803-4eb7-b23c-03ddbf46de44@redhat.com> (raw)
In-Reply-To: <20260811043358.136042-1-rosenp@gmail.com>

On 11/08/2026 06.33, Rosen Penev wrote:
> The threaded irq handler takes the platform device and calls
> platform_get_drvdata() to recover the driver data.  Pass the driver
> data directly as the devm_request_threaded_irq() argument instead,
> dropping the platform_get_drvdata() call.
> 
> Assisted-by: opencode:deepseek-v4-flash-free
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>   drivers/crypto/s5p-sss.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index bdda7b39af85..f20c02e9d646 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -638,8 +638,7 @@ static int s5p_hash_rx(struct s5p_aes_dev *dev)
>   
>   static irqreturn_t s5p_aes_interrupt(int irq, void *dev_id)
>   {
> -	struct platform_device *pdev = dev_id;
> -	struct s5p_aes_dev *dev = platform_get_drvdata(pdev);
> +	struct s5p_aes_dev *dev = dev_id;
>   	struct skcipher_request *req;
>   	int err_dma_tx = 0;
>   	int err_dma_rx = 0;
> @@ -2221,7 +2220,7 @@ static int s5p_aes_probe(struct platform_device *pdev)
>   	}
>   	err = devm_request_threaded_irq(dev, pdata->irq_fc, NULL,
>   					s5p_aes_interrupt, IRQF_ONESHOT,
> -					pdev->name, pdev);
> +					pdev->name, pdata);
>   	if (err < 0) {
>   		dev_warn(dev, "feed control interrupt is not available.\n");
>   		goto err_irq;

Reviewed-by: Thomas Huth <thuth@redhat.com>


  reply	other threads:[~2026-08-11  5:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11  4:33 [PATCH] crypto: s5p-sss: pass s5p_aes_dev to irq handler Rosen Penev
2026-08-11  5:43 ` Thomas Huth [this message]
2026-08-11  5:50 ` Vladimir Zapolskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a736b169-8803-4eb7-b23c-03ddbf46de44@redhat.com \
    --to=thuth@redhat.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=krzk@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=rosenp@gmail.com \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox