From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org, wens@csie.org,
jernej.skrabec@gmail.com, samuel@sholland.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] crypto: sun8i-ce-cipher - use crypto_skcipher_driver_name()
Date: Fri, 25 Apr 2025 15:23:53 +0200 [thread overview]
Message-ID: <aAuM6SmS4Dhsdxfo@Red> (raw)
In-Reply-To: <20250425124517.2225963-2-ovidiu.panait.oss@gmail.com>
Le Fri, Apr 25, 2025 at 03:45:15PM +0300, Ovidiu Panait a écrit :
> Use crypto_skcipher_driver_name() helper from <crypto/skcipher.h>, instead
> of accessing struct crypto_alg directly.
>
> Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
> ---
> drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
> index 05f67661553c..f03a8fa7bfa2 100644
> --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
> +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
> @@ -17,6 +17,7 @@
> #include <linux/io.h>
> #include <linux/pm_runtime.h>
> #include <crypto/scatterwalk.h>
> +#include <crypto/skcipher.h>
> #include <crypto/internal/des.h>
> #include <crypto/internal/skcipher.h>
> #include "sun8i-ce.h"
> @@ -438,7 +439,7 @@ int sun8i_ce_cipher_init(struct crypto_tfm *tfm)
> crypto_skcipher_reqsize(op->fallback_tfm));
>
> memcpy(algt->fbname,
> - crypto_tfm_alg_driver_name(crypto_skcipher_tfm(op->fallback_tfm)),
> + crypto_skcipher_driver_name(op->fallback_tfm),
> CRYPTO_MAX_ALG_NAME);
>
> err = pm_runtime_get_sync(op->ce->dev);
> --
> 2.48.1
>
Acked-by: Corentin LABBE <clabbe.montjoie@gmail.com>
Tested-by: Corentin LABBE <clabbe.montjoie@gmail.com>
Thanks
next prev parent reply other threads:[~2025-04-25 13:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 12:45 [PATCH 1/4] crypto: sun8i-ce-cipher - fix error handling in sun8i_ce_cipher_prepare() Ovidiu Panait
2025-04-25 12:45 ` [PATCH 2/4] crypto: sun8i-ce-cipher - use crypto_skcipher_driver_name() Ovidiu Panait
2025-04-25 13:23 ` Corentin Labbe [this message]
2025-04-28 11:39 ` Herbert Xu
2025-04-25 12:45 ` [PATCH 3/4] crypto: sun8i-ce-cipher - use IS_ENABLED() checks for debugfs stats Ovidiu Panait
2025-04-25 13:30 ` Corentin Labbe
2025-04-25 13:47 ` Ovidiu Panait
2025-04-25 13:53 ` Corentin Labbe
2025-04-25 12:45 ` [PATCH 4/4] crypto: sun8i-ce-cipher - use pm_runtime_resume_and_get() Ovidiu Panait
2025-04-25 13:28 ` Corentin Labbe
2025-04-28 11:53 ` [PATCH 1/4] crypto: sun8i-ce-cipher - fix error handling in sun8i_ce_cipher_prepare() Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAuM6SmS4Dhsdxfo@Red \
--to=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=ovidiu.panait.oss@gmail.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).