From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: arm64/sha1 - Set finalize for short finup
Date: Fri, 25 Apr 2025 21:16:22 +0200 [thread overview]
Message-ID: <aAvfhkjhgIH5FYoC@Red> (raw)
In-Reply-To: <aAtqxbkGYWRGX-Yv@gondor.apana.org.au>
Le Fri, Apr 25, 2025 at 06:58:13PM +0800, Herbert Xu a écrit :
> On Fri, Apr 25, 2025 at 12:42:17PM +0200, Corentin Labbe wrote:
> >
> > No they are still there:
> > [ 2.022921] alg: shash: sha1-ce test failed (wrong result) on test vector 0, cfg="init+update+final aligned buffer"
>
> Thanks, I see the problem now. The zero-length hash doesn't
> set sctx->finalize correctly:
>
> ---8<---
> Always set sctx->finalize before calling finup as it may not have
> been set previously on a short final.
>
> Reported-by: Corentin LABBE <clabbe.montjoie@gmail.com>
> Fixes: b97d31100e36 ("crypto: arm64/sha1 - Use API partial block handling")
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
Tested-by: Corentin LABBE <clabbe.montjoie@gmail.com>
Thanks
prev parent reply other threads:[~2025-04-25 19:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 12:09 all crypto selftests failed on linux-next-20250424 Corentin Labbe
2025-04-24 13:14 ` Herbert Xu
2025-04-24 14:42 ` [PATCH] crypto: Remove CRYPTO_ALG_ENGINE bit Herbert Xu
2025-04-24 20:39 ` Corentin Labbe
2025-04-25 3:33 ` [PATCH] crypto: arm/blake2b - Set FINAL_NONZERO Herbert Xu
2025-04-25 10:42 ` Corentin Labbe
2025-04-25 10:58 ` [PATCH] crypto: arm64/sha1 - Set finalize for short finup Herbert Xu
2025-04-25 19:16 ` Corentin Labbe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAvfhkjhgIH5FYoC@Red \
--to=clabbe.montjoie@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).