From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C5A3253B7C; Wed, 21 May 2025 10:45:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747824324; cv=none; b=eQV0mESaCMsW8s7AyBdp35NbeApuxaF0ayB2AufCfkByiRbnYahzExRwE9Gh9jU79q3CQShuc7DjP2zOB8LNSbS6KR+AcwXeX2D3Z2oaMNF2F3wOQ/1fmdwlBHhnt1drhbBudT7Iz5ZYsAsOU8AH68k8jLUl96nlW9S1J142m2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747824324; c=relaxed/simple; bh=bGejNSfCVWgSr1ZfFclNYtj9IL87+zotGg7h8IGudQs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PPJtpOKXZISlTARJ2zVPt8rAgRydgC5yF8BQ7QY4T2oX9V6Zxcq3sqEHhD7PUI6Q3YlhP5m1z3fxPjDLgQCpcR+jk6KyRFnYsPwRdlPyYjQcr2CQroqpYniXFOVQrbDbjW6PWDmJJBqLrvRhZjCOzx72OPCKz34GbdpcU6lLa8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OO98oYux; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OO98oYux" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3a0adcc3e54so4201939f8f.1; Wed, 21 May 2025 03:45:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747824321; x=1748429121; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=/W9iTls2ZAgc4qnXli7lmiG97t6EfuhQ77mSw3T6AOc=; b=OO98oYux42+TcTw508VBUXPzuNz/cLGi7VfuNgqDM7wNJbubGzN2QelRq7MtG6P0Kx /RF1kbAce6wu6c+T5kva6Hpjbc2VwASfDpsuAzLeNcgcL7UO4HNa7ltdXbqmzFeq/jbf gj4mLnjALVdrQPAZgnHABBJiTBrOf5rgmqj30O1gqOMOB3980sUAOJ5FIknJAIMLvCUu PH5YlWcu55FA2QlTPqNOSFsOXlZf6fYdiZOtqw12fRbKFMXWp25Af69xl+3gj7s/Hzya F3v5fGIid0u6xjlb8FVVMysgIeD3kF86kIOkNt1901qWnxj2DDZpgAJ4dL8THkUmSdFs d4rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747824321; x=1748429121; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/W9iTls2ZAgc4qnXli7lmiG97t6EfuhQ77mSw3T6AOc=; b=HZfeRFin2YAylIMMu2Dvw7vkVVsy8t0yPnwmh61cxmS5f28LCdy8IXopHoeOnWuO6i gKe+dueyljEbW3wAgDyq4YCzjKuA4SZXwZluU3ZilXbZelmWPDmXUIqoXyrdXdmr+t8x iv/+e3d1PP2QI+aAAaYFCZEYWr2EUSB4cfbNeTncD4uuJ0lEv8bek+e0C9xxM6f3QAhV lziLpsDcviygiGReSaSG5/CGtXbpxEMHpmBT6cAVldgheIZ1S4SitH0qHx5NChIXa2U/ G//6HPWxTssO8UCzKnPSFP+zta/He/2eDKefs8NGSISuBKUJXAjRpco5FKfvEFDwwqQG gB9Q== X-Forwarded-Encrypted: i=1; AJvYcCUP4stJAWLqLPPQU4Kk46RUfWWRfAavVUZAQvP/Tp3LrtUlegf60qWqLowWP0m59hWXPyebdK6d7kVOFgOl@vger.kernel.org, AJvYcCV0nprTjnfxWxCoRu6aHNTic2Ha2H5IYiL5V5XqDKtgLZqo6e6eri/oWeJXoJFJJXuEWsicz5s0dTvX8DE=@vger.kernel.org X-Gm-Message-State: AOJu0YyOd6HO/eGNB+MIcq/i4k4wX2uIPVCz0UucfT9ZKHC28mwhVemi VGhU8JyJgTt9ECrUIcQULjP0pWBWBgGcWPF7pqRX/Y7S+UEKQ8JsjBz/ X-Gm-Gg: ASbGncsWL7EGArQy7ffmoEeVCjxddLuzH735TqD5zmnMaBsMmvjA184X7nQsIpce48K kHQCZc2a9T8eBZ/pmRUfWR0+ByvkBcYrlI9J2tXrI4NxiLzJ5n8ieo5SGN4K4SnhWOS/VfXo2g1 gvl9FgovGxUe3Ugfn32E0oKk1p1VZRRbIdR38MVL4Caj0aP9xWWshgHdc2MKUnB17rDfijAKfPL M05KXpm54noMoUnDU1C9z4MGIhsBuIu5/5zoAH0BCX68oKc3twiHAMPTfKVRQ4f4SoVsHqq7wpt wCceVXhgD/p+qwVCsfGPoe8jRKOXsf/RK3qbi18ZUUsUqfm/0cbW X-Google-Smtp-Source: AGHT+IHNm8eCWXpqWiOB470uYCBV2jSEzGedXfvesvpPaSdlSL1MRW2fMlz2O97E+XfF+63q2pKtrg== X-Received: by 2002:a05:6000:2507:b0:3a3:7031:59da with SMTP id ffacd0b85a97d-3a370315bcamr9483123f8f.59.1747824320694; Wed, 21 May 2025 03:45:20 -0700 (PDT) Received: from Red ([2a01:cb1d:897:7800:4a02:2aff:fe07:1efc]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3a35ca88a13sm19100674f8f.74.2025.05.21.03.45.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 May 2025 03:45:19 -0700 (PDT) Date: Wed, 21 May 2025 12:45:18 +0200 From: Corentin Labbe To: Herbert Xu Cc: Klaus Kudielka , Eric Biggers , regressions@lists.linux.dev, linux-kernel@vger.kernel.org, Linux Crypto Mailing List , Boris Brezillon , EBALARD Arnaud , Romain Perier , Arnd Bergmann Subject: Re: [PATCH] crypto: marvell/cesa - Avoid empty transfer descriptor Message-ID: References: <20dde00750d803a9a364ded99dab1e3e22daec77.camel@gmail.com> <20250515182131.GC1411@quark> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Le Wed, May 21, 2025 at 05:16:50PM +0800, Herbert Xu a écrit : > On Wed, May 21, 2025 at 01:06:43PM +0800, Herbert Xu wrote: > > > > Can you please try this patch to see if it makes a difference? > > Actually, please try this one instead. > > Thanks, > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt > -- > diff --git a/drivers/crypto/marvell/cesa/hash.c b/drivers/crypto/marvell/cesa/hash.c > index 6815eddc9068..8a9ea83372c9 100644 > --- a/drivers/crypto/marvell/cesa/hash.c > +++ b/drivers/crypto/marvell/cesa/hash.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > > #include "cesa.h" > > @@ -532,6 +533,7 @@ mv_cesa_ahash_dma_add_cache(struct mv_cesa_tdma_chain *chain, > return ret; > > memcpy(ahashdreq->cache, creq->cache, creq->cache_ptr); > + arch_sync_dma_for_device(ahashdreq->cache_dma, creq->cache_ptr, DMA_TO_DEVICE); > > return mv_cesa_dma_add_data_transfer(chain, > CESA_SA_DATA_SRAM_OFFSET, It fails to build with: ERROR: modpost: "arch_sync_dma_for_device" [drivers/crypto/marvell/cesa/marvell-cesa.ko] undefined!