Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/7] Clean up the crypto testing options
Date: Mon, 12 May 2025 13:46:33 +0800	[thread overview]
Message-ID: <aCGLOd2B5MB0tpPQ@gondor.apana.org.au> (raw)
In-Reply-To: <20250505203345.802740-1-ebiggers@kernel.org>

Eric Biggers <ebiggers@kernel.org> wrote:
> This series reworks the crypto testing kconfig options to fix some
> longstanding issues:
> 
> - Replace the inverted option CONFIG_CRYPTO_MANAGER_DISABLE_TESTS with a
>  regular option CONFIG_CRYPTO_SELFTESTS.
> 
> - Make CONFIG_CRYPTO_SELFTESTS enable the full set of tests by default,
>  removing CONFIG_CRYPTO_MANAGER_EXTRA_TESTS.
> 
> - Automatically enable CONFIG_CRYPTO_MANAGER when needed for the tests.
> 
> - Rename cryptomgr.noextratests to cryptomgr.noslowtests.
> 
> - Remove cryptomgr.panic_on_fail, as panic_on_warn can be used instead.
> 
> - Rename CONFIG_CRYPTO_TEST to CONFIG_CRYPTO_BENCHMARK.
> 
> Changed in v3:
>  - Keep options in defconfigs.
>  - Make CRYPTO_SELFTESTS depend on DEBUG_KERNEL.
> 
> Changed in v2:
>  - Moved selftest lines in lib/crypto/Makefile to appropriate places.
>  - Fixed a commit message.
> 
> Eric Biggers (7):
>  crypto: tcrypt - rename CRYPTO_TEST to CRYPTO_BENCHMARK
>  crypto: testmgr - remove panic_on_fail
>  crypto: testmgr - replace CRYPTO_MANAGER_DISABLE_TESTS with
>    CRYPTO_SELFTESTS
>  crypto: testmgr - make it easier to enable the full set of tests
>  crypto: testmgr - rename noextratests to noslowtests
>  crypto: Kconfig - make CRYPTO_MANAGER a hidden symbol
>  crypto: testmgr - enable CRYPTO_MANAGER when CRYPTO_SELFTESTS
> 
> arch/arm/configs/exynos_defconfig           |   2 +-
> arch/arm/configs/milbeaut_m10v_defconfig    |   3 +-
> arch/arm/configs/pxa_defconfig              |   3 +-
> arch/arm/configs/spitz_defconfig            |   2 +-
> arch/arm64/configs/defconfig                |   2 +-
> arch/loongarch/configs/loongson3_defconfig  |   2 +-
> arch/m68k/configs/amiga_defconfig           |   2 +-
> arch/m68k/configs/apollo_defconfig          |   2 +-
> arch/m68k/configs/atari_defconfig           |   2 +-
> arch/m68k/configs/bvme6000_defconfig        |   2 +-
> arch/m68k/configs/hp300_defconfig           |   2 +-
> arch/m68k/configs/mac_defconfig             |   2 +-
> arch/m68k/configs/multi_defconfig           |   2 +-
> arch/m68k/configs/mvme147_defconfig         |   2 +-
> arch/m68k/configs/mvme16x_defconfig         |   2 +-
> arch/m68k/configs/q40_defconfig             |   2 +-
> arch/m68k/configs/sun3_defconfig            |   2 +-
> arch/m68k/configs/sun3x_defconfig           |   2 +-
> arch/mips/configs/decstation_64_defconfig   |   1 -
> arch/mips/configs/decstation_defconfig      |   1 -
> arch/mips/configs/decstation_r4k_defconfig  |   1 -
> arch/mips/configs/gpr_defconfig             |   2 +-
> arch/mips/configs/ip28_defconfig            |   1 -
> arch/mips/configs/lemote2f_defconfig        |   2 +-
> arch/mips/configs/mtx1_defconfig            |   2 +-
> arch/mips/configs/rb532_defconfig           |   2 +-
> arch/parisc/configs/generic-32bit_defconfig |   2 +-
> arch/parisc/configs/generic-64bit_defconfig |   1 -
> arch/powerpc/configs/g5_defconfig           |   2 +-
> arch/powerpc/configs/powernv_defconfig      |   2 +-
> arch/powerpc/configs/ppc64_defconfig        |   2 +-
> arch/powerpc/configs/ppc64e_defconfig       |   2 +-
> arch/powerpc/configs/ppc6xx_defconfig       |   2 +-
> arch/s390/configs/debug_defconfig           |   4 +-
> arch/s390/configs/defconfig                 |   4 +-
> arch/sh/configs/migor_defconfig             |   1 -
> arch/sparc/configs/sparc64_defconfig        |   2 +-
> crypto/Kconfig                              |  45 ++++----
> crypto/Makefile                             |   2 +-
> crypto/algapi.c                             |   5 +-
> crypto/algboss.c                            |   2 +-
> crypto/api.c                                |   3 +-
> crypto/hkdf.c                               |   2 +-
> crypto/internal.h                           |   5 +-
> crypto/kdf_sp800108.c                       |   2 +-
> crypto/tcrypt.c                             |   8 +-
> crypto/tcrypt.h                             |   4 +-
> crypto/testmgr.c                            | 115 +++++---------------
> include/crypto/internal/simd.h              |   6 +-
> lib/crypto/Makefile                         |  11 +-
> lib/crypto/aescfb.c                         |   2 +-
> lib/crypto/aesgcm.c                         |   2 +-
> lib/crypto/blake2s.c                        |   2 +-
> lib/crypto/chacha20poly1305.c               |   2 +-
> lib/crypto/curve25519.c                     |   2 +-
> 55 files changed, 111 insertions(+), 183 deletions(-)
> 
> 
> base-commit: 64745a9ca890ed60d78162ec511e1983e1946d73

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

      parent reply	other threads:[~2025-05-12  5:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-05 20:33 [PATCH v3 0/7] Clean up the crypto testing options Eric Biggers
2025-05-05 20:33 ` [PATCH v3 1/7] crypto: tcrypt - rename CRYPTO_TEST to CRYPTO_BENCHMARK Eric Biggers
2025-05-08 12:59   ` Geert Uytterhoeven
2025-05-05 20:33 ` [PATCH v3 2/7] crypto: testmgr - remove panic_on_fail Eric Biggers
2025-05-05 20:33 ` [PATCH v3 3/7] crypto: testmgr - replace CRYPTO_MANAGER_DISABLE_TESTS with CRYPTO_SELFTESTS Eric Biggers
2025-06-11 11:41   ` Diederik de Haas
2025-06-11 16:34     ` Eric Biggers
2025-06-13  7:57       ` Diederik de Haas
2025-05-05 20:33 ` [PATCH v3 4/7] crypto: testmgr - make it easier to enable the full set of tests Eric Biggers
2025-05-05 20:33 ` [PATCH v3 5/7] crypto: testmgr - rename noextratests to noslowtests Eric Biggers
2025-05-05 20:33 ` [PATCH v3 6/7] crypto: Kconfig - make CRYPTO_MANAGER a hidden symbol Eric Biggers
2025-05-05 20:33 ` [PATCH v3 7/7] crypto: testmgr - enable CRYPTO_MANAGER when CRYPTO_SELFTESTS Eric Biggers
2025-05-12  5:46 ` Herbert Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCGLOd2B5MB0tpPQ@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=ebiggers@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox