Re: CI found regression in s390 paes-ctr in linux-next

[Herbert Xu <herbert@gondor.apana.org.au>]

On Fri, May 16, 2025 at 09:37:59AM +0200, Harald Freudenberger wrote:
> 
> I've appended a fix for this finding. However, as the reworked PAES is
> already on the way in the s390
> feature branch and will be merged into the next kernel merge window, there
> is no need to apply this
> fix to the upstream kernel. Maybe for stable kernels the fix should be
> integrated.

Good catch! This should probably go into 6.15 as well as stable.
 
> diff --git a/arch/s390/crypto/paes_s390.c b/arch/s390/crypto/paes_s390.c
> index 511093713a6f..8e92a7710294 100644
> --- a/arch/s390/crypto/paes_s390.c
> +++ b/arch/s390/crypto/paes_s390.c
> @@ -874,7 +874,7 @@ static int ctr_paes_crypt(struct skcipher_request *req)
>                 }
>                 memcpy(walk.dst.virt.addr, buf, nbytes);
>                 crypto_inc(walk.iv, AES_BLOCK_SIZE);
> -               rc = skcipher_walk_done(&walk, nbytes);
> +               rc = skcipher_walk_done(&walk, 0);

Acked-by: Herbert Xu <herbert@gondor.apana.org.au>

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt