From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [v4 PATCH 00/11] crypto: Add partial block API and hmac to ahash
Date: Sat, 17 May 2025 09:25:48 +0800 [thread overview]
Message-ID: <aCflnGXIXBr9Qlm2@gondor.apana.org.au> (raw)
In-Reply-To: <20250517011704.GA1220@sol>
On Fri, May 16, 2025 at 06:17:04PM -0700, Eric Biggers wrote:
>
> There's already a huge quality problem with the drivers. The last thing they
> need is to have special code that runs only when an OOM condition occurs, which
> won't be tested.
I totally agree that we have a quality problem with the drivers.
Which is the main reason why I moved the partial block handling
out. The less work the drivers do the less likely they're to
screw it up.
For test coverage, we could easily add something similar to
crypto_reenable_simd_for_test.
Another thing we could do is to just let the drivers fail in these
cases and return ENOMEM and handle the fallback in the Crypto API.
> Can they really not just use mempools?
I don't see how that solves the problem, they can still be exhausted
can't they?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2025-05-17 1:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 5:54 [v4 PATCH 00/11] crypto: Add partial block API and hmac to ahash Herbert Xu
2025-05-15 5:54 ` [v4 PATCH 01/11] crypto: hash - Move core export and import into internel/hash.h Herbert Xu
2025-05-15 5:54 ` [v4 PATCH 02/11] crypto: hash - Add export_core and import_core hooks Herbert Xu
2025-05-15 5:54 ` [v4 PATCH 03/11] crypto: ahash - Handle partial blocks in API Herbert Xu
2025-05-15 5:54 ` [v4 PATCH 04/11] crypto: hmac - Zero shash desc in setkey Herbert Xu
2025-05-15 5:54 ` [v4 PATCH 05/11] crypto: hmac - Add export_core and import_core Herbert Xu
2025-05-15 5:54 ` [v4 PATCH 06/11] crypto: shash - Set reqsize in shash_alg Herbert Xu
2025-05-15 19:32 ` Eric Biggers
2025-05-15 5:54 ` [v4 PATCH 07/11] crypto: algapi - Add driver template support to crypto_inst_setname Herbert Xu
2025-05-15 19:33 ` Eric Biggers
2025-05-15 5:54 ` [v4 PATCH 08/11] crypto: testmgr - Ignore EEXIST on shash allocation Herbert Xu
2025-05-15 5:54 ` [v4 PATCH 09/11] crypto: hmac - Add ahash support Herbert Xu
2025-05-15 5:54 ` [v4 PATCH 10/11] crypto: testmgr - Use ahash for generic tfm Herbert Xu
2025-05-15 19:30 ` Eric Biggers
2025-05-15 5:54 ` [v4 PATCH 11/11] crypto: testmgr - Add hash export format testing Herbert Xu
2025-05-15 19:35 ` [v4 PATCH 00/11] crypto: Add partial block API and hmac to ahash Eric Biggers
2025-05-16 9:23 ` Herbert Xu
2025-05-16 16:43 ` Eric Biggers
2025-05-17 0:45 ` Herbert Xu
2025-05-17 1:17 ` Eric Biggers
2025-05-17 1:25 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCflnGXIXBr9Qlm2@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox