Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Chen Ridong <chenridong@huaweicloud.com>
Cc: steffen.klassert@secunet.com, daniel.m.jordan@oracle.com,
	nstange@suse.de, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org, chenridong@huawei.com,
	wangweiyang2@huawei.com
Subject: Re: [PATCH v2 3/3] padata: avoid UAF for reorder_work
Date: Mon, 26 May 2025 10:16:27 +0800	[thread overview]
Message-ID: <aDPO-9j83gUg-eMg@gondor.apana.org.au> (raw)
In-Reply-To: <faa23d11-4387-4952-bd29-034b4558668c@huaweicloud.com>

On Mon, May 26, 2025 at 09:15:37AM +0800, Chen Ridong wrote:
>
> Unfortunately, I did not reproduce this bug, It was mentioned:
> https://lore.kernel.org/all/20221019083708.27138-6-nstange@suse.de/
> 
> We through that the kworker is asynchronous, and this scenarios may happen.

Right.  I think the only way this can happen is through padata_replace.
That is indeed completely asynchronous and must be guarded against
using the reference count.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2025-05-26  2:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10  6:16 [PATCH v2 0/3] padata: fix UAF issues Chen Ridong
2025-01-10  6:16 ` [PATCH v2 1/3] padata: add pd get/put refcnt helper Chen Ridong
2025-01-13 16:57   ` Daniel Jordan
2025-01-10  6:16 ` [PATCH v2 2/3] padata: fix UAF in padata_reorder Chen Ridong
2025-01-13 16:57   ` Daniel Jordan
2025-01-10  6:16 ` [PATCH v2 3/3] padata: avoid UAF for reorder_work Chen Ridong
2025-01-13 17:00   ` Daniel Jordan
2025-01-14 12:22     ` chenridong
2025-05-23  3:59   ` Herbert Xu
2025-05-26  1:15     ` Chen Ridong
2025-05-26  2:16       ` Herbert Xu [this message]
2025-01-19  4:45 ` [PATCH v2 0/3] padata: fix UAF issues Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aDPO-9j83gUg-eMg@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=chenridong@huawei.com \
    --cc=chenridong@huaweicloud.com \
    --cc=daniel.m.jordan@oracle.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nstange@suse.de \
    --cc=steffen.klassert@secunet.com \
    --cc=wangweiyang2@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox