From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ashish Kalra <Ashish.Kalra@amd.com>
Cc: thomas.lendacky@amd.com, john.allen@amd.com, davem@davemloft.net,
dan.carpenter@linaro.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: ccp: Fix dereferencing uninitialized error pointer
Date: Thu, 29 May 2025 07:26:58 +0800 [thread overview]
Message-ID: <aDebwj8rcuWPIKOa@gondor.apana.org.au> (raw)
In-Reply-To: <20250528202018.78192-1-Ashish.Kalra@amd.com>
On Wed, May 28, 2025 at 08:20:18PM +0000, Ashish Kalra wrote:
>
> @@ -1320,10 +1322,10 @@ static int __sev_platform_init_locked(int *error)
>
> /* Prepare for first SEV guest launch after INIT */
> wbinvd_on_all_cpus();
> - rc = __sev_do_cmd_locked(SEV_CMD_DF_FLUSH, NULL, error);
> + rc = __sev_do_cmd_locked(SEV_CMD_DF_FLUSH, NULL, &dfflush_error);
> if (rc) {
> dev_err(sev->dev, "SEV: DF_FLUSH failed %#x, rc %d\n",
> - *error, rc);
> + dfflush_error, rc);
dfflush_error is never returned to the caller unlike psp_ret, is
this intentional?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-05-28 23:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 20:20 [PATCH] crypto: ccp: Fix dereferencing uninitialized error pointer Ashish Kalra
2025-05-28 23:26 ` Herbert Xu [this message]
2025-05-29 1:19 ` Kalra, Ashish
2025-05-29 19:48 ` Tom Lendacky
2025-06-16 2:46 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDebwj8rcuWPIKOa@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Ashish.Kalra@amd.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=john.allen@amd.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox