From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.actia.se (mail.actia.se [212.181.117.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8563A21E0AF; Thu, 29 May 2025 09:37:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.181.117.226 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748511449; cv=none; b=ouwcqFqI8ibPBOvQWWLhsqfJoZkUN0RMjyKp5w1Ai5VgAqklxcIm8IbkxURYxd5b1enWB3LXLxpWZAeQZKrGqYjwEohs/kzWbp7/JnPXB+XWn5Cjxw6g1Tj/WB00pxJv4HjfkxNWe9He2KA8euR0416/nBa6agrRFerYC31i44Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748511449; c=relaxed/simple; bh=0A2hvECib8AzzgAufejxO42tkHm5UBhV7QzN/YWOs3k=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=r6ev5xRjiL8glDpk/M07qtJug/xwXxtgA3kcA8zqirKNSVMWCfL1wMbXfI5h09ap1O21354/jaoVNFP/iYzJDjuacWdMtLrgvRjkNlqFBep+OB+pe9yCm4Ubn49BSoO//0lVUFDJMifurrCRww3nA6MrK41VmufpUPc/IH6aFGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=actia.se; spf=pass smtp.mailfrom=actia.se; arc=none smtp.client-ip=212.181.117.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=actia.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=actia.se Received: from S036ANL.actianordic.se (10.12.31.117) by S035ANL.actianordic.se (10.12.31.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 29 May 2025 11:37:17 +0200 Received: from S036ANL.actianordic.se ([fe80::e13e:1feb:4ea6:ec69]) by S036ANL.actianordic.se ([fe80::e13e:1feb:4ea6:ec69%3]) with mapi id 15.01.2507.039; Thu, 29 May 2025 11:37:17 +0200 From: John Ernberg To: Rob Herring CC: =?iso-8859-2?Q?Horia_Geant=E3?= , Pankaj Gupta , Gaurav Jain , Herbert Xu , "David S . Miller" , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , "Frank Li" , Pengutronix Kernel Team , "Fabio Estevam" , Thomas Richard , "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 3/4] dt-bindings: crypto: fsl,sec-v4.0: Add power domains for iMX8QM and iMX8QXP Thread-Topic: [PATCH v3 3/4] dt-bindings: crypto: fsl,sec-v4.0: Add power domains for iMX8QM and iMX8QXP Thread-Index: AQHbz97TDhLekXOKbkmerT2PfEO8vrPodECAgADE/QA= Date: Thu, 29 May 2025 09:37:17 +0000 Message-ID: References: <20250528144259.2603914-1-john.ernberg@actia.se> <20250528144259.2603914-4-john.ernberg@actia.se> <20250528215209.GA862463-robh@kernel.org> In-Reply-To: <20250528215209.GA862463-robh@kernel.org> Accept-Language: en-US, sv-SE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-esetresult: clean, is OK x-esetid: 37303A2956B14453637562 Content-Type: text/plain; charset="iso-8859-2" Content-ID: <11D1FBF7FEE64642BE637CBA54B3C320@actia.se> Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Rob, On Wed, May 28, 2025 at 04:52:09PM -0500, Rob Herring wrote: > On Wed, May 28, 2025 at 02:43:07PM +0000, John Ernberg wrote: > > NXP SoCs like the iMX8QM, iMX8QXP or iMX8DXP use power domains for > > resource management. > >=20 > > Allow specifying them for such SoCs. > >=20 > > Signed-off-by: John Ernberg > >=20 > > --- > >=20 > > v3: > > - Fix warnings discovered by Rob Herring's bot > > - Declare the compatibles correctly (Krzysztof Kozlowski) > >=20 > > v2: > > - Adjust commit message (Frank Li) > > - Only allow power-domains when compatible with imx8qm (Frank Li) > > --- > > .../bindings/crypto/fsl,sec-v4.0.yaml | 45 ++++++++++++++++++- > > 1 file changed, 44 insertions(+), 1 deletion(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml= b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml > > index 75afa441e019..a4ada0e2d97c 100644 > > --- a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml > > +++ b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml > > @@ -46,6 +46,7 @@ properties: > > - items: > > - enum: > > - fsl,imx6ul-caam > > + - fsl,imx8qm-caam > > - fsl,sec-v5.0 > > - const: fsl,sec-v4.0 > > - const: fsl,sec-v4.0 > > @@ -77,6 +78,9 @@ properties: > > interrupts: > > maxItems: 1 > > =20 > > + power-domains: > > + maxItems: 1 > > + > > fsl,sec-era: > > description: Defines the 'ERA' of the SEC device. > > $ref: /schemas/types.yaml#/definitions/uint32 > > @@ -106,7 +110,9 @@ patternProperties: > > - const: fsl,sec-v5.0-job-ring > > - const: fsl,sec-v4.0-job-ring > > - items: > > - - const: fsl,sec-v5.0-job-ring > > + - enum: > > + - fsl,imx8qm-job-ring > > + - fsl,sec-v5.0-job-ring > > - const: fsl,sec-v4.0-job-ring > > - const: fsl,sec-v4.0-job-ring > > =20 > > @@ -116,6 +122,9 @@ patternProperties: > > interrupts: > > maxItems: 1 > > =20 > > + power-domains: > > + maxItems: 1 > > + > > fsl,liodn: > > description: > > Specifies the LIODN to be used in conjunction with the ppid-= to-liodn > > @@ -212,6 +221,40 @@ required: > > - reg > > - ranges > > =20 > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: fsl,imx8qm-caam > > + then: > > + required: > > + - power-domains > > + else: > > + properties: > > + power-domains: false > > + > > + - if: >=20 > This 'if' belongs under the '^jr@[0-9a-f]+$' subschema which will then=20 > remote a level here. >=20 This is what I had in v2 [1], which your bot pointed out is an unexpected if-statement [2]. Or should I have wrapped it in an allOf: even though it was a single if:? jernberg % pip install --upgrade dtschema Requirement already satisfied: dtschema in ./.venv/lib/python3.13/site-= packages (2025.2) [1]: https://lore.kernel.org/linux-crypto/20250527071552.1424997-4-john.ern= berg@actia.se/ [2]: https://lore.kernel.org/linux-crypto/174833819381.3537254.550804710081= 7417003.robh@kernel.org/ Would you mind also letting me know the command line you run validation with in the CI? I didn't see the v2 (at first, needed W=3D1 for that) nor the v3 complaint in my runs before sending. Thanks! // John Ernberg > > + patternProperties: > > + '^jr@[0-9a-f]+$': > > + type: object > > + properties: > > + compatible: > > + contains: > > + const: fsl,imx8qm-job-ring > > + then: > > + patternProperties: > > + '^jr@[0-9a-f]+$': > > + type: object > > + required: > > + - power-domains > > + else: > > + patternProperties: > > + '^jr@[0-9a-f]+$': > > + type: object > > + properties: > > + power-domains: false > > + > > additionalProperties: false > > =20 > > examples: > > --=20 > > 2.49.0=