From: Herbert Xu <herbert@gondor.apana.org.au>
To: “ChengZhenghan” <chengzhenghan@uniontech.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, "H . Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86_crypto: Fix build warnings about export.h
Date: Wed, 11 Jun 2025 10:57:46 +0800 [thread overview]
Message-ID: <aEjwqtotEEH8QMHB@gondor.apana.org.au> (raw)
In-Reply-To: <20250611025131.22055-1-chengzhenghan@uniontech.com>
On Wed, Jun 11, 2025 at 10:51:31AM +0800, “ChengZhenghan” wrote:
> From: ChengZhenghan <chengzhenghan@uniontech.com>
>
> I got some build warnings with W=1:
> arch/x86/coco/sev/core.c:
> arch/x86/crypto/aria_aesni_avx2_glue.c:
> warning: EXPORT_SYMBOL() is used,
> but #include <linux/export.h> is missing
> arch/x86/crypto/aria_aesni_avx_glue.c:
> warning: EXPORT_SYMBOL() is used,
> but #include <linux/export.h> is missing
> arch/x86/crypto/camellia_aesni_avx_glue.c:
> warning: EXPORT_SYMBOL() is used,
> but #include <linux/export.h> is missing
> arch/x86/crypto/camellia_glue.c: warning:
> EXPORT_SYMBOL() is used,
> but #include <linux/export.h> is missing
> arch/x86/crypto/curve25519-x86_64.c:
> warning: EXPORT_SYMBOL() is used,
> but #include <linux/export.h> is missing
> arch/x86/crypto/serpent_avx_glue.c:
> warning: EXPORT_SYMBOL() is used,
> but #include <linux/export.h> is missing
> arch/x86/crypto/sm4_aesni_avx_glue.c:
> warning: EXPORT_SYMBOL() is used,
> but #include <linux/export.h> is missing
> arch/x86/crypto/twofish_glue.c:
> warning: EXPORT_SYMBOL() is used,
> but #include <linux/export.h> is missing
> arch/x86/crypto/twofish_glue_3way.c:
> warning: EXPORT_SYMBOL() is used,
> but #include <linux/export.h> is missing
> so I fixed these build warnings for x86_64.
>
> Signed-off-by: ChengZhenghan <chengzhenghan@uniontech.com>
> ---
> arch/x86/crypto/aria_aesni_avx2_glue.c | 1 +
> arch/x86/crypto/aria_aesni_avx_glue.c | 1 +
> arch/x86/crypto/camellia_aesni_avx_glue.c | 1 +
> arch/x86/crypto/camellia_glue.c | 1 +
> arch/x86/crypto/curve25519-x86_64.c | 1 +
> arch/x86/crypto/serpent_avx_glue.c | 1 +
> arch/x86/crypto/sm4_aesni_avx_glue.c | 1 +
> arch/x86/crypto/twofish_glue.c | 1 +
> arch/x86/crypto/twofish_glue_3way.c | 1 +
> 9 files changed, 9 insertions(+)
module.h always includes export.h so this is not needed at all.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-06-11 2:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 2:51 [PATCH] x86_crypto: Fix build warnings about export.h “ChengZhenghan”
2025-06-11 2:57 ` Herbert Xu [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-06-11 3:33 “ChengZhenghan”
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEjwqtotEEH8QMHB@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=bp@alien8.de \
--cc=chengzhenghan@uniontech.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox