From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Gilad Ben-Yossef <gilad@benyossef.com>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: ccree - Don't use %pK through printk
Date: Mon, 23 Jun 2025 17:25:33 +0800 [thread overview]
Message-ID: <aFkdjTsui7BZE5Kt@gondor.apana.org.au> (raw)
In-Reply-To: <20250618-restricted-pointers-crypto-v1-1-e354644aa381@linutronix.de>
On Wed, Jun 18, 2025 at 09:10:18AM +0200, Thomas Weißschuh wrote:
> In the past %pK was preferable to %p as it would not leak raw pointer
> values into the kernel log.
> Since commit ad67b74d2469 ("printk: hash addresses printed with %p")
> the regular %p has been improved to avoid this issue.
> Furthermore, restricted pointers ("%pK") were never meant to be used
> through printk(). They can still unintentionally leak raw pointers or
> acquire sleeping locks in atomic contexts.
>
> Switch to the regular pointer formatting which is safer and
> easier to reason about.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
> drivers/crypto/ccree/cc_buffer_mgr.c | 54 ++++++++++++++++++------------------
> drivers/crypto/ccree/cc_cipher.c | 4 +--
> drivers/crypto/ccree/cc_hash.c | 30 ++++++++++----------
> 3 files changed, 44 insertions(+), 44 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2025-06-23 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 7:10 [PATCH] crypto: ccree - Don't use %pK through printk Thomas Weißschuh
2025-06-23 9:25 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFkdjTsui7BZE5Kt@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=gilad@benyossef.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox