From: Herbert Xu <herbert@gondor.apana.org.au>
To: Pei Xiao <xiaopei01@kylinos.cn>
Cc: syzbot+01fcd39a0d90cdb0e3df@syzkaller.appspotmail.com,
davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] [patch] syz test
Date: Tue, 21 Oct 2025 11:12:55 +0800 [thread overview]
Message-ID: <aPb6NzJovIM6CFud@gondor.apana.org.au> (raw)
In-Reply-To: <6556ef55c42ea17d82561b8182d9453b19d66a62.1761016077.git.xiaopei01@kylinos.cn>
On Tue, Oct 21, 2025 at 11:08:54AM +0800, Pei Xiao wrote:
> #syz test
> ---
> lib/crypto/x86/poly1305.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/crypto/x86/poly1305.h b/lib/crypto/x86/poly1305.h
> index ee92e3740a78..3b9f1024a18d 100644
> --- a/lib/crypto/x86/poly1305.h
> +++ b/lib/crypto/x86/poly1305.h
> @@ -8,6 +8,7 @@
> #include <linux/jump_label.h>
> #include <linux/kernel.h>
> #include <linux/sizes.h>
> +#include <linux/string.h>
>
> struct poly1305_arch_internal {
> union {
> @@ -86,6 +87,7 @@ static __ro_after_init DEFINE_STATIC_KEY_FALSE(poly1305_use_avx512);
> static void poly1305_block_init(struct poly1305_block_state *state,
> const u8 raw_key[POLY1305_BLOCK_SIZE])
> {
> + memset(state, 0, sizeof(struct poly1305_block_state));
> poly1305_init_x86_64(state, raw_key);
> }
Please stop sending random patches to me. If you want to test
random patches, send it to syzbot only and not anyone else.
When you hit an uninitialised access in crypto code, it's usually
the caller at fault. So I suggest that you focus your energies
further up the stack.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-10-21 3:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 21:07 [syzbot] [crypto?] KMSAN: uninit-value in poly1305_blocks syzbot
2025-10-21 1:54 ` [PATCH] [patch] syz test Pei Xiao
2025-10-21 2:51 ` [syzbot] [crypto?] KMSAN: uninit-value in poly1305_blocks syzbot
2025-10-21 3:08 ` [PATCH] [patch] syz test Pei Xiao
2025-10-21 3:12 ` Herbert Xu [this message]
2025-10-21 4:46 ` [syzbot] [crypto?] KMSAN: uninit-value in poly1305_blocks syzbot
[not found] <6fnt99vd47a5-6fo0chqsqcpq@nsmail8.2--kylin--1>
2025-10-21 5:25 ` [PATCH] [patch] syz test Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPb6NzJovIM6CFud@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+01fcd39a0d90cdb0e3df@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=xiaopei01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox