From: Namhyung Kim <namhyung@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-perf-users@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
Fangrui Song <maskray@sourceware.org>,
Pablo Galindo <pablogsal@gmail.com>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2 0/3] perf genelf: BLAKE2s build ID generation
Date: Wed, 17 Dec 2025 07:25:01 -0800 [thread overview]
Message-ID: <aULLTawpDh26XHDB@google.com> (raw)
In-Reply-To: <20251209015729.23253-1-ebiggers@kernel.org>
Hello,
On Mon, Dec 08, 2025 at 05:57:26PM -0800, Eric Biggers wrote:
> This series upgrades perf's build ID generation to a more modern hash
> algorithm and switches to an incremental hashing API.
>
> It also fixes an issue where different (code, symtab, strsym) tuples
> didn't necessarily result in different hashes.
>
> Note that the size of the build ID field stays the same.
>
> This applies to the perf-tools-next branch of
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git
>
> Changed in v2:
> - Split into three patches
> - Improved a couple comments
>
> Eric Biggers (3):
> perf util: Add BLAKE2s support
> perf genelf: Switch from SHA-1 to BLAKE2s for build ID generation
> perf util: Remove SHA-1 code
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks a lot!
Namhyung
>
> tools/perf/tests/util.c | 85 +++++++++++++--------
> tools/perf/util/Build | 2 +-
> tools/perf/util/blake2s.c | 151 ++++++++++++++++++++++++++++++++++++++
> tools/perf/util/blake2s.h | 73 ++++++++++++++++++
> tools/perf/util/genelf.c | 58 +++++++--------
> tools/perf/util/sha1.c | 97 ------------------------
> tools/perf/util/sha1.h | 6 --
> 7 files changed, 309 insertions(+), 163 deletions(-)
> create mode 100644 tools/perf/util/blake2s.c
> create mode 100644 tools/perf/util/blake2s.h
> delete mode 100644 tools/perf/util/sha1.c
> delete mode 100644 tools/perf/util/sha1.h
>
>
> base-commit: 2eeb09fe1c5173b659929f92fee4461796ca8c14
> --
> 2.52.0
>
prev parent reply other threads:[~2025-12-17 15:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 1:57 [PATCH v2 0/3] perf genelf: BLAKE2s build ID generation Eric Biggers
2025-12-09 1:57 ` [PATCH v2 1/3] perf util: Add BLAKE2s support Eric Biggers
2025-12-09 1:57 ` [PATCH v2 2/3] perf genelf: Switch from SHA-1 to BLAKE2s for build ID generation Eric Biggers
2025-12-09 1:57 ` [PATCH v2 3/3] perf util: Remove SHA-1 code Eric Biggers
2025-12-17 15:25 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aULLTawpDh26XHDB@google.com \
--to=namhyung@kernel.org \
--cc=Jason@zx2c4.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ebiggers@kernel.org \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maskray@sourceware.org \
--cc=mingo@redhat.com \
--cc=pablogsal@gmail.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).