From: Herbert Xu <herbert@gondor.apana.org.au>
To: Chenghai Huang <huangchenghai2@huawei.com>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, linuxarm@openeuler.org,
liulongfang@huawei.com, qianweili@huawei.com,
linwenkai6@hisilicon.com, wangzhou1@hisilicon.com
Subject: Re: [PATCH] crypto: hisilicon/qm - fix incorrect judgment in qm_get_complete_eqe_num()
Date: Fri, 19 Dec 2025 14:56:33 +0800 [thread overview]
Message-ID: <aUT3IW8vlYKwWDt2@gondor.apana.org.au> (raw)
In-Reply-To: <20251120132124.1779549-1-huangchenghai2@huawei.com>
On Thu, Nov 20, 2025 at 09:21:24PM +0800, Chenghai Huang wrote:
> In qm_get_complete_eqe_num(), the function entry has already
> checked whether the interrupt is valid, so the interrupt event
> can be processed directly. Currently, the interrupt valid bit is
> being checked again redundantly, and no interrupt processing is
> performed. Therefore, the loop condition should be modified to
> directly process the interrupt event, and use do while instead of
> the current while loop, because the condition is always satisfied
> on the first iteration.
>
> Fixes: f5a332980a68 ("crypto: hisilicon/qm - add the save operation of eqe and aeqe")
> Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
> ---
> drivers/crypto/hisilicon/qm.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-12-19 6:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 13:21 [PATCH] crypto: hisilicon/qm - fix incorrect judgment in qm_get_complete_eqe_num() Chenghai Huang
2025-12-19 6:56 ` Herbert Xu [this message]
2025-12-22 3:00 ` huangchenghai
2025-12-22 4:22 ` Herbert Xu
2025-12-23 1:46 ` huangchenghai
2025-12-24 2:52 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUT3IW8vlYKwWDt2@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=huangchenghai2@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=linwenkai6@hisilicon.com \
--cc=liulongfang@huawei.com \
--cc=qianweili@huawei.com \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox