From: Antoine Tenart <atenart@kernel.org>
To: Aleksander Jan Bajkowski <olek2@wp.pl>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] crypto: safexcel - Group authenc ciphersuites
Date: Tue, 3 Feb 2026 10:42:21 +0100 [thread overview]
Message-ID: <aYHC31jHukTIPRxy@kwain> (raw)
In-Reply-To: <20260202202203.124015-1-olek2@wp.pl>
On Mon, Feb 02, 2026 at 09:21:07PM +0100, Aleksander Jan Bajkowski wrote:
> Move authenc(sha1,des) and authenc(sha1,3des) ciphersuites to appropriate
> groups. No functional changes intended.
>
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Acked-by: Antoine Tenart <atenart@kernel.org>
Thanks!
> ---
> drivers/crypto/inside-secure/safexcel.c | 4 ++--
> drivers/crypto/inside-secure/safexcel.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
> index c3b2b22934b7..9c00573abd8c 100644
> --- a/drivers/crypto/inside-secure/safexcel.c
> +++ b/drivers/crypto/inside-secure/safexcel.c
> @@ -1209,7 +1209,6 @@ static struct safexcel_alg_template *safexcel_algs[] = {
> &safexcel_alg_authenc_hmac_sha256_cbc_aes,
> &safexcel_alg_authenc_hmac_sha384_cbc_aes,
> &safexcel_alg_authenc_hmac_sha512_cbc_aes,
> - &safexcel_alg_authenc_hmac_sha1_cbc_des3_ede,
> &safexcel_alg_authenc_hmac_sha1_ctr_aes,
> &safexcel_alg_authenc_hmac_sha224_ctr_aes,
> &safexcel_alg_authenc_hmac_sha256_ctr_aes,
> @@ -1241,11 +1240,12 @@ static struct safexcel_alg_template *safexcel_algs[] = {
> &safexcel_alg_hmac_sha3_256,
> &safexcel_alg_hmac_sha3_384,
> &safexcel_alg_hmac_sha3_512,
> - &safexcel_alg_authenc_hmac_sha1_cbc_des,
> + &safexcel_alg_authenc_hmac_sha1_cbc_des3_ede,
> &safexcel_alg_authenc_hmac_sha256_cbc_des3_ede,
> &safexcel_alg_authenc_hmac_sha224_cbc_des3_ede,
> &safexcel_alg_authenc_hmac_sha512_cbc_des3_ede,
> &safexcel_alg_authenc_hmac_sha384_cbc_des3_ede,
> + &safexcel_alg_authenc_hmac_sha1_cbc_des,
> &safexcel_alg_authenc_hmac_sha256_cbc_des,
> &safexcel_alg_authenc_hmac_sha224_cbc_des,
> &safexcel_alg_authenc_hmac_sha512_cbc_des,
> diff --git a/drivers/crypto/inside-secure/safexcel.h b/drivers/crypto/inside-secure/safexcel.h
> index 0f27367a85fa..ca012e2845f7 100644
> --- a/drivers/crypto/inside-secure/safexcel.h
> +++ b/drivers/crypto/inside-secure/safexcel.h
> @@ -950,7 +950,6 @@ extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha224_cbc_aes;
> extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha256_cbc_aes;
> extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha384_cbc_aes;
> extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha512_cbc_aes;
> -extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha1_cbc_des3_ede;
> extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha1_ctr_aes;
> extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha224_ctr_aes;
> extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha256_ctr_aes;
> @@ -982,11 +981,12 @@ extern struct safexcel_alg_template safexcel_alg_hmac_sha3_224;
> extern struct safexcel_alg_template safexcel_alg_hmac_sha3_256;
> extern struct safexcel_alg_template safexcel_alg_hmac_sha3_384;
> extern struct safexcel_alg_template safexcel_alg_hmac_sha3_512;
> -extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha1_cbc_des;
> +extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha1_cbc_des3_ede;
> extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha256_cbc_des3_ede;
> extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha224_cbc_des3_ede;
> extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha512_cbc_des3_ede;
> extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha384_cbc_des3_ede;
> +extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha1_cbc_des;
> extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha256_cbc_des;
> extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha224_cbc_des;
> extern struct safexcel_alg_template safexcel_alg_authenc_hmac_sha512_cbc_des;
> --
> 2.47.3
>
prev parent reply other threads:[~2026-02-03 9:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 20:21 [PATCH 1/2] crypto: safexcel - Group authenc ciphersuites Aleksander Jan Bajkowski
2026-02-02 20:21 ` [PATCH 2/2] crypto: safexcel - Add support for authenc(hmac(md5),*) suites Aleksander Jan Bajkowski
2026-02-03 9:41 ` Antoine Tenart
2026-02-03 18:13 ` Aleksander Jan Bajkowski
2026-02-03 9:42 ` Antoine Tenart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYHC31jHukTIPRxy@kwain \
--to=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olek2@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox