From: Sumit Garg <sumit.garg@kernel.org>
To: rouven.czerwinski@linaro.org
Cc: "Jens Wiklander" <jens.wiklander@linaro.org>,
"Olivia Mackall" <olivia@selenic.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Clément Léger" <clement.leger@bootlin.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-rtc@vger.kernel.org
Subject: Re: [PATCH 1/3] optee: simplify OP-TEE context match
Date: Tue, 10 Feb 2026 10:52:00 +0530 [thread overview]
Message-ID: <aYrAeEiqG7iwXm_w@sumit-xelite> (raw)
In-Reply-To: <20260126-optee-simplify-context-match-v1-1-d4104e526cb6@linaro.org>
On Mon, Jan 26, 2026 at 11:11:24AM +0100, Rouven Czerwinski via B4 Relay wrote:
> From: Rouven Czerwinski <rouven.czerwinski@linaro.org>
>
> Simplify the TEE implementor ID match by returning the boolean
> expression directly instead of going through an if/else.
>
> Signed-off-by: Rouven Czerwinski <rouven.czerwinski@linaro.org>
> ---
> drivers/tee/optee/device.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
-Sumit
> diff --git a/drivers/tee/optee/device.c b/drivers/tee/optee/device.c
> index 950b4661d5df..4c85b04d6004 100644
> --- a/drivers/tee/optee/device.c
> +++ b/drivers/tee/optee/device.c
> @@ -13,10 +13,7 @@
>
> static int optee_ctx_match(struct tee_ioctl_version_data *ver, const void *data)
> {
> - if (ver->impl_id == TEE_IMPL_ID_OPTEE)
> - return 1;
> - else
> - return 0;
> + return (ver->impl_id == TEE_IMPL_ID_OPTEE);
> }
>
> static int get_devices(struct tee_context *ctx, u32 session,
>
> --
> 2.52.0
>
>
>
next prev parent reply other threads:[~2026-02-10 5:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 10:11 [PATCH 0/3] OP-TEE/OP-TEE drivers: simplify context matches Rouven Czerwinski via B4 Relay
2026-01-26 10:11 ` [PATCH 1/3] optee: simplify OP-TEE context match Rouven Czerwinski via B4 Relay
2026-02-10 5:22 ` Sumit Garg [this message]
2026-03-04 9:34 ` Jens Wiklander
2026-01-26 10:11 ` [PATCH 2/3] hwrng: optee - " Rouven Czerwinski via B4 Relay
2026-02-06 10:57 ` Herbert Xu
2026-01-26 10:11 ` [PATCH 3/3] rtc: optee: " Rouven Czerwinski via B4 Relay
2026-01-29 16:05 ` Alexandre Belloni
2026-01-30 15:03 ` Rouven Czerwinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYrAeEiqG7iwXm_w@sumit-xelite \
--to=sumit.garg@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=clement.leger@bootlin.com \
--cc=herbert@gondor.apana.org.au \
--cc=jens.wiklander@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=olivia@selenic.com \
--cc=op-tee@lists.trustedfirmware.org \
--cc=rouven.czerwinski@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox