From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from abb.hmeau.com (abb.hmeau.com [180.181.231.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5548B3502A3; Sat, 21 Mar 2026 08:41:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=180.181.231.80 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774082517; cv=none; b=qOqzhb797zJgYH84x5yMto2zkxryUSZv65NcYABwB+MJUM7rwyLyq1xtvj4FMzUht4Yc+Sl+y31om1AdyUxAWYpV1xsyHSVP1F1q+D8spybR45Pi+oToBx+Z0uJDJkvCF/+W2xm8TzZe1DrPVJjvLt47ek9o9E6Sc9Mn6r8tviM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774082517; c=relaxed/simple; bh=BUetTRhkxdQWfs0le0sjotn07EfTu62f0LNIZv865Qw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I+VXC/N5XvKlvZ6sZHR8kp5uOEjiQt7yIXqansn0D/rB6AKVssklTIxhqS5dSmEBjCwGKQH1AgwihC6IEMoJf2ZY8dWoD96dQFS/kXnndy0jOKUoPf3C1jMd6CZRrD7pepG1uW1BQuUcUWqVegFT+oJ8vDgzh0KF8SH2PteIaXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au; spf=pass smtp.mailfrom=gondor.apana.org.au; dkim=pass (2048-bit key) header.d=gondor.apana.org.au header.i=@gondor.apana.org.au header.b=m3o7dTNy; arc=none smtp.client-ip=180.181.231.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gondor.apana.org.au header.i=@gondor.apana.org.au header.b="m3o7dTNy" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gondor.apana.org.au; s=h01; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:cc:to:subject:message-id:date: from:content-type:reply-to; bh=R9boKfUgb1sWuyro63MYYbVoVEMu2ElqOcoSMt/jWGA=; b=m3o7dTNyfcMIidEDeLkcs8KJdsCpWA1cNP2kqmDlNYY98UfjQChF9PkvEpPBj3h7JhAA8luRuId vNc/w/kdX2VU8RDOrQRZP2AXW+g7YQks6a6qsz3up1beDY7dUxA7hp9kEDpf8qVHWt4yGB/KEUaoz i4X6m1+hjXI3/DB0ZZ2FgQB81BQwWD7A7MEN1ozW5VM9JlW1rHiG6sXFuM/6LRsH+wBjn2pVpwNpf 69inLEUAOZGUbMnCEyXBvis4stwZv/ShhsNjIRnmxuoym3sVjJhdgvujgjemAyySScAw5Ct7i/a3m zm1kwXAYdz50P/0A+S+fkeoVGOyx6imXsegA==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1w3ru0-00GJ4b-2p; Sat, 21 Mar 2026 16:41:49 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Sat, 21 Mar 2026 17:41:48 +0900 Date: Sat, 21 Mar 2026 17:41:48 +0900 From: Herbert Xu To: Wesley Atwell Cc: davem@davemloft.net, dhowells@redhat.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: krb5enc - fix sleepable flag handling in encrypt dispatch Message-ID: References: <20260309062624.1848239-1-atwellwea@gmail.com> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260309062624.1848239-1-atwellwea@gmail.com> On Mon, Mar 09, 2026 at 12:26:24AM -0600, Wesley Atwell wrote: > krb5enc_encrypt_ahash_done() continues encryption from an ahash > completion callback by calling krb5enc_dispatch_encrypt(). > > That helper takes a flags argument for this continuation path, but it > ignored that argument and reused aead_request_flags(req) when setting > up the skcipher subrequest callback. This can incorrectly preserve > CRYPTO_TFM_REQ_MAY_SLEEP when the encrypt step is started from callback > context. > > Preserve the original request flags but clear > CRYPTO_TFM_REQ_MAY_SLEEP for the callback continuation path, and use > the caller-supplied flags when setting up the skcipher subrequest. > > Fixes: d1775a177f7f ("crypto: Add 'krb5enc' hash and cipher AEAD algorithm") > Assisted-by: Codex:GPT-5 > Signed-off-by: Wesley Atwell > --- > crypto/krb5enc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt