From: Herbert Xu <herbert@gondor.apana.org.au>
To: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
Cc: davem@davemloft.net, ebiggers@kernel.org, ardb@kernel.org,
kees@kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: tcrypt: stop ahash speed tests when setkey fails
Date: Sat, 14 Mar 2026 14:11:34 +0900 [thread overview]
Message-ID: <abTuBiFU5ekM2YBy@gondor.apana.org.au> (raw)
In-Reply-To: <20260303000641.770327-1-saeed.mirzamohammadi@oracle.com>
On Mon, Mar 02, 2026 at 04:06:40PM -0800, Saeed Mirzamohammadi wrote:
> The async hash speed path ignores the return code from
> crypto_ahash_setkey(). If the caller picks an unsupported key length,
> the transform keeps whatever key state it already has and the speed test
> still runs, producing misleading numbers, hence bail out of the loop when
> setkey fails.
>
> Signed-off-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
> ---
> crypto/tcrypt.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-03-14 5:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 0:06 [PATCH] crypto: tcrypt: stop ahash speed tests when setkey fails Saeed Mirzamohammadi
2026-03-14 5:11 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abTuBiFU5ekM2YBy@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=kees@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saeed.mirzamohammadi@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox