From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com [209.85.221.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EA1B25E837 for ; Sat, 10 May 2025 01:11:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746839511; cv=none; b=htonY0XgLltNyR+qFYPmaqymKT0LaCCKIkGo2nT/RgGfcc25X2otZ32QXdbcAnqr58X4faiUeh5RhlX0T5L7zDy5nJltAt9DgHVEiIrjLUbkoLqoKdhznGpf19imRWZj+GJ3NmtJDrNmWqzAq8eBNW80Nb09FSxJ6mVufstoXYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746839511; c=relaxed/simple; bh=i9UWPnsl5DxTMjQs0U8KJm25qIUiVeowujVOw/wT+6U=; h=From:References:In-Reply-To:MIME-Version:Date:Message-ID:Subject: To:Cc:Content-Type; b=eDLq4XM6H8q5QUjMfjBR6aunWegwq/7+CZK81ov8Aoggk2HMijFSnVtIiwdEo+Y5sxxK3iKBO/DtBWT6slERMW+iT9ZFPWzA7MU6G17KFXNbpqIN9LIXzEdnj2kMQQmiBVs5IeBRbIObi08g1lxz/7vLpGTo1UfqRXGrhMhmQMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=BLPsfpR5; arc=none smtp.client-ip=209.85.221.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="BLPsfpR5" Received: by mail-vk1-f171.google.com with SMTP id 71dfb90a1353d-52403e39a23so1672073e0c.2 for ; Fri, 09 May 2025 18:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1746839508; x=1747444308; darn=vger.kernel.org; h=cc:to:subject:message-id:date:thread-index:mime-version:in-reply-to :references:from:from:to:cc:subject:date:message-id:reply-to; bh=i9UWPnsl5DxTMjQs0U8KJm25qIUiVeowujVOw/wT+6U=; b=BLPsfpR56g/scNzs9nfDlZwFxK877fjhcyDjPLwVJShD2+BlqcM/NY4U922QSBIm2Z JEb7+QesJWwL20Q79eTAmuRAe1pqZrkVj+LvXEZqhMGdyLr21CeDzePl8KcVQ2mTpCao eEzmd63u9k+OQAdPmmX5UX/yMZ2y79OZ+obqI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746839508; x=1747444308; h=cc:to:subject:message-id:date:thread-index:mime-version:in-reply-to :references:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i9UWPnsl5DxTMjQs0U8KJm25qIUiVeowujVOw/wT+6U=; b=uQDhccPho18imitg+bKZDi2dpQ0+N2o8VT0ckyH/X6EjSdxP08vsXDvhLAEti/AM1I qG7ZcEHF3mXLC57EKyjYLFe4Ugzm53mmfwNrhCGLioDVrE7DkJy2yV+RHxi9y2lULaFJ 4dB2LPs0Ch1I4at+VU7LlCdC5J7fYDkkxWMYZXjoP1mN4d0s4f8P5EI7Ec1XcftcD7uE 0KcRwxXWfW0tmBn3HNf+nHqBmsrv4kGmKaYgrW6LDbN9eCUmOQdLSJtsLJTSy3pMM1oo 2zNvIQjxEein6tCvRNHmk6DxhAOg5D+Iyyb1iK1Bh4EMi0PUW6eHS4O8givUc4mywr/+ K5pg== X-Forwarded-Encrypted: i=1; AJvYcCWx6aS24ls9AogMCJdwr09wj9jw/2AdUDIytLo2yt9D354ac/to59mrX9saosjNo1KFgvEH7d9q2W2Jht8=@vger.kernel.org X-Gm-Message-State: AOJu0YwYy/tipDuXS9qnuWZ9wVOepC6ndIwBcjXRFEGFnGzSWacH7TWQ +vqV5ZAGdJWqdV5CSH7QHtSFIDpOZ91HFL8YqfkVfyBf+TWsE74pacg4SlVR4ciu8VCA4NmEthr 1OsauzwGh3NS6QbZWcEIXY6gese8D969WI+Zm X-Gm-Gg: ASbGncv1uDXlCr1BS4TkKe64U2+nlXTuLNtgQnhNmU/ojze7blvYrJutMhobuGvybrB xgaOvD2k2Ub7F2ueOnYeFZZH7/XmVF15NUWreFuTLu4EhRWsTrSxhryOC+wELkX4nhk90kODbJt tArdj1tHRklwnIQT4HykVFUnEqTkEHZBEiuw== X-Google-Smtp-Source: AGHT+IE4sXvyNXjG8WNaadif7bxOPhLOe1y6Ry36uIIGYYJZ+WmMezrfm/fmhMVuBl3XBtzwwZHReyMQPEltI3gIWXE= X-Received: by 2002:a05:6122:3d0d:b0:529:1a6a:cc2f with SMTP id 71dfb90a1353d-52c53d2f883mr5596955e0c.7.1746839508202; Fri, 09 May 2025 18:11:48 -0700 (PDT) From: William Zhang References: <20250406-bcmbca-peripherals-arm-v2-0-22130836c2ed@linaro.org> In-Reply-To: Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKk0Iba5S5vFfMGFNn0Sizjy9mbxwHgAqlcsintLgA= Date: Fri, 9 May 2025 18:11:49 -0700 X-Gm-Features: AX0GCFt3K95Ms68nC87j0n5IDLINSfLeg-FuKXyKdXYqk17d76prYmspWacWdcY Message-ID: Subject: RE: [PATCH v2 00/12] ARM: bcm: Add some BCMBCA peripherals To: Florian Fainelli , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Anand Gore , Kursad Oney , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Broadcom internal kernel review list , Olivia Mackall , Ray Jui , Scott Branden Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, Krzysztof Kozlowski Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000006242120634bdc405" --0000000000006242120634bdc405 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Linus, > -----Original Message----- > From: Florian Fainelli > Sent: Saturday, April 26, 2025 1:49 AM > To: Linus Walleij ; Rob Herring > ; > Krzysztof Kozlowski ; Conor Dooley > ; William Zhang ; > Anand Gore ; Kursad Oney > ; Florian Fainelli > ; Rafa=C5=82 Mi=C5=82ecki ; > Broadcom > internal kernel review list ; > Olivia > Mackall ; Ray Jui ; Scott Branden > > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux- > crypto@vger.kernel.org; Krzysztof Kozlowski > > Subject: Re: [PATCH v2 00/12] ARM: bcm: Add some BCMBCA peripherals > > > > On 4/6/2025 5:32 PM, Linus Walleij wrote: > > This adds a bunch peripherals to the Broadcom BRCMBCA > > SoC:s that I happened to find documentation for in some > > vendor header files. > > > > It started when I added a bunch of peripherals for the > > BCM6846, and this included really helpful peripherals > > such as the PL081 DMA, for which I think the most common > > usecase is to be used as a memcpy engine to offload > > transfer of blocks from NAND flash to/from the NAND > > flash controller (at least this is how the STMicro > > FSMC controller was using it). > > > > So I took a sweep and added all the stuff that has > > bindings to: > > > > ARM: > > - BCM6846 > > - BCM6855 > > - BCM6878 > > - BCM63138 > > - BCM63148 > > - BCM63178 > > > > ARM64: > > - BCM4908 > > - BCM6856 > > - BCM6858 > > - BCM63158 > > > > There are several "holes" in this SoC list, I simply > > just fixed those that I happened to run into documentation > > for. > > > > Unfortunately while very similar, some IP blocks vary > > slightly in version, the GPIO block is differently > > integrated on different systems, and the interrupt assignments > > are completely different, so it's safest to add these to each > > DTSI individually. > > > > I add the interrupt binding for the RNG block in the > > process as this exists even if Linux isn't using the > > IRQ, and I put the RNG and DMA engines as default-enabled > > because they are not routed to the outside and should > > "just work" so why not. > > > > I did a rogue patch adding some stuff to BCM6756 based > > on guessed but eventually dropped it. If someone has > > docs for this SoC I can add it. > > > > Signed-off-by: Linus Walleij > > Linus can you resubmit a v3 addressing William's feedback? I will drop > your series for now. Thanks! > -- > Florian I wonder if you get a chance to review my feedbacks on this series? Let me know if you have any questions. Thanks, William --0000000000006242120634bdc405 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQYwYJKoZIhvcNAQcCoIIQVDCCEFACAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3HMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBU8wggQ3oAMCAQICDDG6HZcbcVdEvVYk4TANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAxMTMxNDVaFw0yNTA5MTAxMTMxNDVaMIGQ MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xFjAUBgNVBAMTDVdpbGxpYW0gWmhhbmcxKTAnBgkqhkiG9w0B CQEWGndpbGxpYW0uemhhbmdAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB CgKCAQEAyKF+RmY29Wvfmfe3L8J4rZNmBIvRmrWKI5td5L0vlpPMCEzUkVhBdL2N9cDP0rPScvWL CX/9cI1a2BUy/6/ZT5j9PhcUn6A3kwKFGukLY2itfKaDrP3ANVJGhBXPVJ6sx55GF41PkiL2EMnY 7LJGNpl9WHYrw8VqtRediPyXq8M6ZWGPZWxygsE6y1pOkEk9qLpvXTb2Epxk2JWcQFZQCDWVULue YDZuuBJwnyCzevMoPtVYPharioL5H3BRnQi8YoTXH7/uRo33dewYFm474yFjwwnt82TFtveVZkVq 6h4WIQ4wTcwFfET8zMkELnGzS5SHCl8sPD+lNxxJ1JDZYwIDAQABo4IB2zCCAdcwDgYDVR0PAQH/ BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3VyZS5nbG9i YWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEGCCsGAQUF BzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAy MDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93d3cuZ2xv YmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6hjhodHRw Oi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNybDAlBgNV HREEHjAcgRp3aWxsaWFtLnpoYW5nQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEFBQcDBDAf BgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUq65GzwZxydFHjjYEU/9h xHhPWlwwDQYJKoZIhvcNAQELBQADggEBAA2hGG3JPAdGPH0ZdohGUCIVjKz+U+EFuIDbS6A/5jqX VhYAxZlzj7tSjUIM7G7IhyfqPC46GKJ/4x+Amz1Z6YxNGy71L68kYD6hIbBcA5AM42QBUufly6Oa /ppSz3WoflVyFFQ5YXniZ+eU+2/cdnYZg4aVUnFjimOF5o3NfMLzOkhQNxbaDjFUfUYD8hKmU6v4 0vUBj8KZ9Gi1LIagLKUREn8jku0lcLsRbnJ5Ey5ScajC/FESPyYWasOW8j8/1EoJksmhbYGKNS6C urb/KlmDGfVrIRYDbL0ckhGQIP5c6L+kSQZ2sHnQK0e0WgIaZYxaPYeY5u0GLCOze+3vyRMxggJg MIICXAIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYD VQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwxuh2XG3FXRL1W JOEwDQYJYIZIAWUDBAIBBQCggccwLwYJKoZIhvcNAQkEMSIEIIVPdrVjlcOl4I8Q0jep9/rh92DI ogokI8lm7HZahfyrMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTI1 MDUxMDAxMTE0OFowXAYJKoZIhvcNAQkPMU8wTTALBglghkgBZQMEASowCwYJYIZIAWUDBAEWMAsG CWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQcwCwYJYIZIAWUDBAIBMA0GCSqGSIb3 DQEBAQUABIIBAF2w0r0/SVecb3jpat3fLGJzTbzfy9dPfKkrUvKhxLFrHsjCpvaibjq9aI68I3yn +E1CvE0fGBnQQcqexrcygBt1GD/uz0FpZq2bwNUzlsFpTrtgWdRGUlxGfWPqjOa062vzRzCaTA3E QX5iH7uf9ZENKebD9dChv55mB3OQwpCWBQwiPqMOVkikujRa1ggStYgsqJTL93sVUyNYdiDGjzaK +Jyq+HRJcRXoHHTzR1v815FBz5WHe6yBzutuUB97fkHgGVIe2BkebhT2H0Ybayjb8Qniy/y0+ysP H1H1F3aJ9PWBuMxcYAHY/Uz3ekqiaDe8XwC9+zx5KWbpJcUCMxk= --0000000000006242120634bdc405--