From: Herbert Xu <herbert@gondor.apana.org.au>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com,
atharvd440@gmail.com, andriy.shevchenko@intel.com,
ahsan.atta@intel.com
Subject: Re: [PATCH 0/2] crypto: qat - fix and cleanup RAS sysfs show functions
Date: Fri, 3 Apr 2026 09:04:53 +0800 [thread overview]
Message-ID: <ac8SNWjvV7KT8_az@gondor.apana.org.au> (raw)
In-Reply-To: <20260324181936.122027-1-giovanni.cabiddu@intel.com>
On Tue, Mar 24, 2026 at 06:17:22PM +0000, Giovanni Cabiddu wrote:
> This small series fixes a type mismatch bug in the RAS error counter
> sysfs interface of the Intel QAT driver and follows up with a cleanup to
> use the recommended sysfs output API.
>
> Patch #1 fixes a type mismatch in the RAS sysfs show callbacks: the
> local counter variable was declared as 'unsigned long' while
> atomic_read() returns int, causing an implicit conversion and a wrong
> '%ld' format specifier. Patch #2 follows up by migrating the same
> callbacks from scnprintf() to the recommended sysfs_emit() API.
>
> Atharv Dubey (1):
> crypto: qat - replace scnprintf() with sysfs_emit()
>
> Giovanni Cabiddu (1):
> crypto: qat - fix type mismatch in RAS sysfs show functions
>
> .../intel/qat/qat_common/adf_sysfs_ras_counters.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>
> base-commit: 8da773efcd2b505cca6bbd13aad4a28fda61cf37
> --
> 2.53.0
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-04-03 1:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 18:17 [PATCH 0/2] crypto: qat - fix and cleanup RAS sysfs show functions Giovanni Cabiddu
2026-03-24 18:17 ` [PATCH 1/2] crypto: qat - fix type mismatch in " Giovanni Cabiddu
2026-03-24 18:17 ` [PATCH 2/2] crypto: qat - replace scnprintf() with sysfs_emit() Giovanni Cabiddu
2026-04-03 1:04 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac8SNWjvV7KT8_az@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ahsan.atta@intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=atharvd440@gmail.com \
--cc=giovanni.cabiddu@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox