From: Herbert Xu <herbert@gondor.apana.org.au>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com,
Laurent M Coquerel <laurent.m.coquerel@intel.com>
Subject: Re: [PATCH v2] crypto: deflate - fix decompression window size
Date: Mon, 20 Apr 2026 16:50:55 +0800 [thread overview]
Message-ID: <aeXo79eNiYnJ2ImV@gondor.apana.org.au> (raw)
In-Reply-To: <aeEWf4j+VO0FziNj@gcabiddu-mobl.ger.corp.intel.com>
On Thu, Apr 16, 2026 at 06:03:59PM +0100, Giovanni Cabiddu wrote:
>
> I'm reworking the acomp/BTRFS set, and that will be included there.
I'd prefer a standalone parameters patch-set, with the first user
being zram.
> I don't think this should be treated as a parameter. A decompressor must
> be able to handle any valid DEFLATE stream. RFC1951 (section 3.3) [1]
> states that while a compressor may restrict parameters such as window
> size, a compliant decompressor must accept the full range defined by the
> specification.
I thought this is the whole point of parameters. Different parameters
would generate compression output that may not be decompressed unless
you used the same set of parameters.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2026-04-20 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 9:59 [PATCH v2] crypto: deflate - fix decompression window size Giovanni Cabiddu
2026-04-03 0:25 ` Herbert Xu
2026-04-16 17:03 ` Giovanni Cabiddu
2026-04-20 8:50 ` Herbert Xu [this message]
2026-04-20 10:37 ` Giovanni Cabiddu
2026-04-21 3:01 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeXo79eNiYnJ2ImV@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=giovanni.cabiddu@intel.com \
--cc=laurent.m.coquerel@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox