From: Weiming Shi <bestswngs@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Howells <dhowells@redhat.com>,
Lukas Wunner <lukas@wunner.de>, Ignat Korchagin <ignat@linux.win>,
"David S . Miller" <davem@davemloft.net>,
Vivek Goyal <vgoyal@redhat.com>, Kees Cook <kees@kernel.org>,
keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
Xiang Mei <xmei5@asu.edu>, Jarkko Sakkinen <jarkko@kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Mimi Zohar <zohar@linux.ibm.com>
Subject: Re: [PATCH] crypto: fix OOB read in pefile_digest_pe_contents
Date: Tue, 5 May 2026 15:12:35 +0800 [thread overview]
Message-ID: <afmYY6bDIrKwbwBT@Air.local> (raw)
In-Reply-To: <afmEQ5ove_8fqEhH@gondor.apana.org.au>
On 26-05-05 13:46, Herbert Xu wrote:
> >
> > diff --git a/crypto/asymmetric_keys/verify_pefile.c b/crypto/asymmetric_keys/verify_pefile.c
> > index 1f3b227ba7f2..cec99db14129 100644
> > --- a/crypto/asymmetric_keys/verify_pefile.c
> > +++ b/crypto/asymmetric_keys/verify_pefile.c
> > @@ -305,6 +305,8 @@ static int pefile_digest_pe_contents(const void *pebuf, unsigned int pelen,
> >
> > if (pelen > hashed_bytes) {
> > tmp = hashed_bytes + ctx->certs_size;
> > + if (tmp <= hashed_bytes || pelen < tmp)
> > + return -ELIBBAD;
>
> I know nothing about this but why should pelen == tmp fail?
>
> Cheers,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Hi Herbert,
Do you mean this should be `pelen <= tmp` ?
pelen == tmp means the cert table sits right at EOF with no trailing data
in between - that's a legitimate layout.
Weiming Shi
next prev parent reply other threads:[~2026-05-05 7:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 17:36 [PATCH] crypto: fix OOB read in pefile_digest_pe_contents Weiming Shi
2026-05-05 5:46 ` Herbert Xu
2026-05-05 7:12 ` Weiming Shi [this message]
2026-05-05 8:23 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afmYY6bDIrKwbwBT@Air.local \
--to=bestswngs@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=ignat@linux.win \
--cc=jarkko@kernel.org \
--cc=kees@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=vgoyal@redhat.com \
--cc=xmei5@asu.edu \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox