From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from abb.hmeau.com (abb.hmeau.com [180.181.231.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79AD23E4C61; Tue, 5 May 2026 08:23:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=180.181.231.80 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777969399; cv=none; b=PWL5tj2gCjZoW1mO/C5zUMUq6fnTOhq5ZsJ/1P0M3TddFt8FgVjMKThIXM16TKyTOLU5ZnrcHAS49ArEg4yuJisi/r3NG69Tute4vPOMt34wIvfOKBrmFFX813sU5nUH54bDxRje/SO7WV5o3Ah7bwyPpcVs6Kuc7P/tPxhE4Ig= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777969399; c=relaxed/simple; bh=s8tRxJbbfwrCnkwj+IvJip8DNnvpQbZWo/ddocX/+VE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J0sWKjgVdtEzn60H9R8WvJDYYtL62ZWEVyRy+pBER1X9jyeusrQiZpcSVRN+ya+pm9Aayo9/M8UYRHJnql8JhBBsPtPcDfc85movhVOEGI2NXEFsCHjYTcFllZFJNLnW+aYF/oQTJPXSWcWEsRGWnnduePA8/7LczXXczY3kTHc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au; spf=pass smtp.mailfrom=gondor.apana.org.au; dkim=pass (2048-bit key) header.d=gondor.apana.org.au header.i=@gondor.apana.org.au header.b=B0+ihSpr; arc=none smtp.client-ip=180.181.231.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gondor.apana.org.au header.i=@gondor.apana.org.au header.b="B0+ihSpr" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gondor.apana.org.au; s=h01; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:cc:to:subject:message-id:date: from:content-type:reply-to; bh=AZzxSu0X3NGt+Y8kBHu5qY0cSTMYriJuRZ0POdO9TTA=; b=B0+ihSpr1z/xxR2YpHkjsjuDUnSZE7p5tmXCTk05LO5WrUTbBBu+qSNDqULGXY61nGNiuszq425 5EvZgUOzoMBB9sl/T/PNPcus0pDNTQ5I6aVAOo+RgIKDLGMsozM2BIlT9+L166EjlZdJIXm+PAE6T GVR2pdcsqhmYkqsl2lfMj2XlPke2AdsL36PA+BmMvEod//kcGCkOa+Hzh5edZzGS3mKixvAstaN/v 7iUWVj0qy6js6uEXv/d8hMb6YnvQcktUbKgKg0YJye296Xyy0cyedkYL597ERbM1ZcgMoUa+ZB0Ca h/FKWhOr7WzDW8dxrB//YcmbNIm619ym8e7Q==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1wKB3a-00BMcq-2K; Tue, 05 May 2026 16:23:07 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Tue, 05 May 2026 16:23:06 +0800 Date: Tue, 5 May 2026 16:23:06 +0800 From: Herbert Xu To: Rosen Penev Cc: linux-crypto@vger.kernel.org, "David S. Miller" , Kees Cook , "Gustavo A. R. Silva" , open list , "open list:KERNEL HARDENING (not covered by other areas):Keyword:b__counted_by(_le|_be)?b" Subject: Re: [PATCHv2] talitos: allocate channels with main struct Message-ID: References: <20260505073705.8810-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260505073705.8810-1-rosenp@gmail.com> On Tue, May 05, 2026 at 12:37:05AM -0700, Rosen Penev wrote: > Use a flexible array member to combine allocations. > > Add __counted_by for extra runtime analysis. > > Signed-off-by: Rosen Penev > --- > v2: add check for of_property_read_u32 > drivers/crypto/talitos.c | 19 +++++++------------ > drivers/crypto/talitos.h | 5 +++-- > 2 files changed, 10 insertions(+), 14 deletions(-) > > diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c > index bc61d0fe3514..e1f009684216 100644 > --- a/drivers/crypto/talitos.c > +++ b/drivers/crypto/talitos.c > @@ -3409,14 +3409,20 @@ static int talitos_probe(struct platform_device *ofdev) > struct device *dev = &ofdev->dev; > struct device_node *np = ofdev->dev.of_node; > struct talitos_private *priv; > + unsigned int num_channels; > int i, err; > int stride; > struct resource *res; > > - priv = devm_kzalloc(dev, sizeof(struct talitos_private), GFP_KERNEL); > + if (of_property_read_u32(np, "fsl,num-channels", &num_channels)) > + num_channels = 0; Does this driver still work with zero channels? It should just fail the probe. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt