From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Markus Schneider-Pargmann <msp@baylibre.com>,
George Cherian <gcherian@marvell.com>,
Srujana Challa <schalla@marvell.com>,
Bharat Bhushan <bbhushan2@marvell.com>,
Kees Cook <kees@kernel.org>,
Thomas Fourier <fourier.thomas@gmail.com>,
Amit Singh Tomar <amitsinght@marvell.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: Drop explicit assigment of 0 in pci_device_id array
Date: Fri, 15 May 2026 18:13:55 +0800 [thread overview]
Message-ID: <agbx44LfQembS6X7@gondor.apana.org.au> (raw)
In-Reply-To: <20260504153221.2151136-2-u.kleine-koenig@baylibre.com>
On Mon, May 04, 2026 at 05:32:21PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Assigning .driver_data for drivers that don't use this struct member is
> just noise that can better be dropped. The same applies for an explicit
> zero in the terminating entry. Drop these.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
> Hello,
>
> this is a preparing change for making struct pci_device_id::driver_data an
> anonymous union (similar to
> https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@baylibre.com/).
> This requires named initializers for .driver_data, but dropping unused
> assignments is still better and a nice cleanup on its own.
>
> Best regards
> Uwe
>
> drivers/crypto/cavium/cpt/cptvf_main.c | 4 ++--
> drivers/crypto/cavium/nitrox/nitrox_main.c | 4 ++--
> drivers/crypto/marvell/octeontx/otx_cptvf_main.c | 4 ++--
> drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c | 6 +++---
> 4 files changed, 9 insertions(+), 9 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-05-15 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 15:32 [PATCH] crypto: Drop explicit assigment of 0 in pci_device_id array Uwe Kleine-König (The Capable Hub)
2026-05-15 10:13 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agbx44LfQembS6X7@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=amitsinght@marvell.com \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=fourier.thomas@gmail.com \
--cc=gcherian@marvell.com \
--cc=kees@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=schalla@marvell.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox