From: Herbert Xu <herbert@gondor.apana.org.au>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: George Cherian <gcherian@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Srujana Challa <schalla@marvell.com>,
Bharat Bhushan <bbhushan2@marvell.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: Move MODULE_DEVICE_TABLE next to the table itself
Date: Fri, 15 May 2026 18:19:12 +0800 [thread overview]
Message-ID: <agbzIHiVF4sN0pcX@gondor.apana.org.au> (raw)
In-Reply-To: <20260505102948.191683-2-krzysztof.kozlowski@oss.qualcomm.com>
On Tue, May 05, 2026 at 12:29:49PM +0200, Krzysztof Kozlowski wrote:
> By convention MODULE_DEVICE_TABLE() immediately follows the ID table it
> exports, because this is easier to read and verify. It also makes more
> sense since #ifdef for ACPI or OF could hide both of them.
>
> Most of the privers already have this correctly placed, so adjust
> the missing ones. No functional impact.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> drivers/crypto/cavium/cpt/cptpf_main.c | 2 +-
> drivers/crypto/cavium/cpt/cptvf_main.c | 2 +-
> drivers/crypto/marvell/octeontx/otx_cptpf_main.c | 2 +-
> drivers/crypto/marvell/octeontx/otx_cptvf_main.c | 2 +-
> drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c | 2 +-
> drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-05-15 10:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 10:29 [PATCH] crypto: Move MODULE_DEVICE_TABLE next to the table itself Krzysztof Kozlowski
2026-05-15 10:19 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agbzIHiVF4sN0pcX@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=gcherian@marvell.com \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schalla@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox