From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from abb.hmeau.com (abb.hmeau.com [180.181.231.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8475736C0BD; Thu, 28 May 2026 23:24:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=180.181.231.80 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780010652; cv=none; b=mxWGv9DEEQ07/vyurJaT2fhDxkZbpZ4Wp3onzWBBbQVWJRvp1U1kDXrSG30bGv7Pd8h+X1VlroKP7QgJyreXdr2SJa5PQ2LINIOFStGuArxYr2uOji2fFw0iHYjWBcEdLsuf4V+VSfj90cf1+kSYDkHPhDxyEFNMy3Tq1l9RCEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780010652; c=relaxed/simple; bh=hXRI8pfr26o6q/3esmAA2MiquFHTg5G5hTsEehgBKrY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kaaOYgAfYtqzKnaEcLAszE/Hl1C6vzbVWpMVw7EJpVOy2FuFIGgXOO1emAfY/Jc+9oebWjAtaFb+OMBOC/pzf30z5p+ry/DH5flg4LCWZ687QXL2LRJ/DddT++ArbtHPYLvf1QqbExcg+9KaNqFzWt6E0VUS+6RCRoVJRBh4L1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au; spf=pass smtp.mailfrom=gondor.apana.org.au; dkim=pass (2048-bit key) header.d=gondor.apana.org.au header.i=@gondor.apana.org.au header.b=HMvn/BAD; arc=none smtp.client-ip=180.181.231.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gondor.apana.org.au header.i=@gondor.apana.org.au header.b="HMvn/BAD" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gondor.apana.org.au; s=h01; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:cc:to:subject:message-id:date: from:content-type:reply-to; bh=aD/+6gFCYQh5HNcAXs9wYEDF3vBE3AuA9RB/SyyLfAA=; b=HMvn/BADPsIDm9luuhFAVwZrm92JE01uHvyPY5ACtFqSGons4TDEckc19TkOKc6IYu4uol/MmrL yzzvCYeg273B1VTorRlWV8JZf9xCb5M/iqskusC4Kg6lL7JnjKSnxnVwaySVGMsTys4KLKhJ/o+nw vutgbd9IED0pCpXc5hLhsdCWfr9Ec2o7FpO/CPvL9N/P52QjadqpBZHBY1c3jWQ0UY8Tam+hPG5xC MLSBAtU7ft4fpNtxmxYECeZdN12k4f8SsyocU+RT9zS8VPQRNSSotIgCKEWcsGUf629/IzsnXaSwY iHTjIlnvCgoyN0wus8yQdlRo0wjCHzLgP7Cw==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1wSk4w-000Z2S-2v; Fri, 29 May 2026 07:23:55 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 29 May 2026 07:23:54 +0800 Date: Fri, 29 May 2026 07:23:54 +0800 From: Herbert Xu To: Eric Biggers Cc: netdev@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , Neal Cardwell , Kuniyuki Iwashima , "David S . Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Simon Horman , Ard Biesheuvel , "Jason A . Donenfeld" , Dmitry Safonov <0x7f454c46@gmail.com> Subject: Re: [PATCH net-next 0/6] Remove unused support for crypto tfm cloning Message-ID: References: <20260522053028.91165-1-ebiggers@kernel.org> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260522053028.91165-1-ebiggers@kernel.org> On Fri, May 22, 2026 at 12:30:22AM -0500, Eric Biggers wrote: > This series is targeting net-next because it depends on > "net/tcp: Remove tcp_sigpool". So far no commits in cryptodev conflict > with this, so I suggest that this be taken through net-next for 7.2. > > This series removes support for transformation cloning from the crypto > API. Now that the TCP-AO and TCP-MD5 code no longer uses it, it no > longer has a user. And it's unlikely that a new one will appear, as the > library API solves the problem in a much simpler and more efficient way. > > This feature also regressed performance for all crypto API users, since > it changed crypto transformation objects into reference-counted objects. > That added expensive atomic operations. The refcount is reverted by > this series, thus fixing the performance regression. > > A subset of this was previously sent in > https://lore.kernel.org/r/20260307224341.5644-1-ebiggers@kernel.org > Compared to that version, this version is a bit more comprehensive. > > Eric Biggers (6): > crypto: hash - Remove support for cloning hash tfms > crypto: cipher - Remove crypto_clone_cipher() > crypto: api - Remove crypto_clone_tfm() > crypto: api - Remove per-tfm refcount > crypto: api - Fold __crypto_alloc_tfmgfp() into __crypto_alloc_tfm() > crypto: api - Fold crypto_alloc_tfmmem() into crypto_create_tfm_node() > > crypto/ahash.c | 70 ----------------------------- > crypto/api.c | 76 +++++--------------------------- > crypto/cipher.c | 28 ------------ > crypto/cmac.c | 16 ------- > crypto/cryptd.c | 16 ------- > crypto/hmac.c | 31 ------------- > crypto/internal.h | 10 ----- > crypto/shash.c | 37 ---------------- > include/crypto/hash.h | 8 ---- > include/crypto/internal/cipher.h | 2 - > include/linux/crypto.h | 1 - > 11 files changed, 10 insertions(+), 285 deletions(-) > > > base-commit: 1a1f055318d82e64485a6ff8420e5f70b4267998 > -- > 2.54.0 Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt