Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jihong Min <hurryman2212@gmail.com>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	"David S . Miller" <davem@davemloft.net>,
	Antoine Tenart <atenart@kernel.org>,
	Christian Marangi <ansuelsmth@gmail.com>,
	Richard van Schagen <vschagen@icloud.com>,
	Benjamin Larsson <benjamin.larsson@genexis.eu>,
	Mieczyslaw Nalewaj <namiltd@yahoo.com>,
	Aleksander Jan Bajkowski <olek2@wp.pl>
Subject: Re: [PATCH v2 1/5] crypto: eip93: guard DMA cleanup on uninitialized mappings
Date: Fri, 17 Jul 2026 17:52:11 +1000	[thread overview]
Message-ID: <alnfK4PRK4rkDfoZ@gondor.apana.org.au> (raw)
In-Reply-To: <20260707171537.467608-2-hurryman2212@gmail.com>

On Wed, Jul 08, 2026 at 02:15:33AM +0900, Jihong Min wrote:
>
> @@ -534,8 +536,10 @@ int eip93_send_req(struct crypto_async_request *async,
>  	memcpy(iv, reqiv, rctx->ivsize);
>  
>  	rctx->sa_state = kzalloc(sizeof(*rctx->sa_state), GFP_KERNEL);
> -	if (!rctx->sa_state)
> -		return -ENOMEM;
> +	if (!rctx->sa_state) {
> +		err = -ENOMEM;
> +		goto free_sa_state;
> +	}

What kind of non-sense is this?

Please stop wasting my time.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2026-07-17  7:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07 17:15 [PATCH v2 0/5] crypto: eip93: fix request lifetime and completion handling Jihong Min
2026-07-07 17:15 ` [PATCH v2 1/5] crypto: eip93: guard DMA cleanup on uninitialized mappings Jihong Min
2026-07-17  7:52   ` Herbert Xu [this message]
2026-07-07 17:15 ` [PATCH v2 2/5] crypto: eip93: reject HMAC requests before setkey Jihong Min
2026-07-07 17:15 ` [PATCH v2 3/5] crypto: eip93: use request-local SA records for cipher requests Jihong Min
2026-07-07 17:15 ` [PATCH v2 4/5] crypto: eip93: order result descriptor reads after PE_READY Jihong Min
2026-07-07 17:15 ` [PATCH v2 5/5] crypto: eip93: handle request ID exhaustion Jihong Min

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alnfK4PRK4rkDfoZ@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=ansuelsmth@gmail.com \
    --cc=atenart@kernel.org \
    --cc=benjamin.larsson@genexis.eu \
    --cc=davem@davemloft.net \
    --cc=hurryman2212@gmail.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namiltd@yahoo.com \
    --cc=olek2@wp.pl \
    --cc=vschagen@icloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox