From: Herbert Xu <herbert@gondor.apana.org.au>
To: Pan Chuang <panchuang@vivo.com>
Cc: "Olivia Mackall" <olivia@selenic.com>,
"Hadar Gat" <hadar.gat@arm.com>, "Frank Li" <Frank.Li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Jia Jie Ho" <jiajie.ho@starfivetech.com>,
"Deepak Saxena" <dsaxena@plexity.net>,
"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Aleksander Jan Bajkowski" <olek2@wp.pl>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<imx@lists.linux.dev>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] hwrng: drivers - Remove redundant dev_err()/dev_err_probe()
Date: Fri, 17 Jul 2026 18:16:49 +1000 [thread overview]
Message-ID: <alnk8UV-b2uTMsll@gondor.apana.org.au> (raw)
In-Reply-To: <20260710105318.376496-2-panchuang@vivo.com>
On Fri, Jul 10, 2026 at 06:53:06PM +0800, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() and dev_err_probe() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
> drivers/char/hw_random/airoha-trng.c | 4 +---
> drivers/char/hw_random/cctrng.c | 2 +-
> drivers/char/hw_random/imx-rngc.c | 2 +-
> drivers/char/hw_random/jh7110-trng.c | 3 +--
> drivers/char/hw_random/omap-rng.c | 5 +----
> drivers/char/hw_random/xgene-rng.c | 2 +-
> 6 files changed, 6 insertions(+), 12 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-07-17 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 10:53 [PATCH 0/3] char: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-10 10:53 ` [PATCH 1/3] hwrng: drivers - Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 8:16 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alnk8UV-b2uTMsll@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=dakr@kernel.org \
--cc=dsaxena@plexity.net \
--cc=festevam@gmail.com \
--cc=hadar.gat@arm.com \
--cc=imx@lists.linux.dev \
--cc=jiajie.ho@starfivetech.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=olek2@wp.pl \
--cc=olivia@selenic.com \
--cc=panchuang@vivo.com \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox