From: Herbert Xu <herbert@gondor.apana.org.au>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: "David S. Miller" <davem@davemloft.net>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: atmel-sha204a - clear RNG data from memory
Date: Fri, 17 Jul 2026 18:15:00 +1000 [thread overview]
Message-ID: <alnkhHBvJe88caUS@gondor.apana.org.au> (raw)
In-Reply-To: <20260708150359.545852-2-thorsten.blum@linux.dev>
On Wed, Jul 08, 2026 at 05:04:00PM +0200, Thorsten Blum wrote:
> In atmel_sha204a_rng_read(), use memzero_explicit() to clear the local
> stack variable cmd before it goes out of scope, since cmd.data may still
> hold the last 32 random bytes.
>
> Since atmel_sha204a_rng_done() caches work_data in hwrng::priv, and its
> response data is later used as RNG entropy, use kfree_sensitive() to
> clear the cached data on transaction failure and device removal.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/crypto/atmel-sha204a.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-07-17 8:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 15:04 [PATCH] crypto: atmel-sha204a - clear RNG data from memory Thorsten Blum
2026-07-17 8:15 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alnkhHBvJe88caUS@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox