Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Changwei Zou <changwei.zou@canonical.com>
Cc: Martin.Kepplinger-Novakovic@ginzinger.com, davem@davemloft.net,
	herbert@gondor.apana.org.au, ignat@linux.win,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	martink@posteo.de
Subject: Re: [PATCH v4] crypto: rsassa-pkcs1 - Avoid cacheline sharing with underlying driver
Date: Thu, 30 Jul 2026 13:35:44 +0200	[thread overview]
Message-ID: <ams3ED05SiobrDap@wunner.de> (raw)
In-Reply-To: <20260730112026.1612066-1-changwei.zou@canonical.com>

On Thu, Jul 30, 2026 at 09:20:26PM +1000, Changwei Zou wrote:
> +++ b/crypto/rsassa-pkcs1.c
> @@ -227,6 +227,7 @@ static int rsassa_pkcs1_verify(struct crypto_sig *tfm,
>  	struct scatterlist sg;
>  	unsigned int dst_len;
>  	unsigned int pos;
> +	u8 *key_buf __free(kfree_sensitive) = NULL;
>  	u8 *out_buf;
>  	int err;
>

Hm, why use an additional key_buf variable instead of using the existing
out_buf?

key_buf also seems to be misnomer, the buffer contains a digest.

For neatness, could you move the new declaration up below the one for
child_req so that the variable declarations sort of adhere to inverse
christmas tree convention.

Thanks,

Lukas

  reply	other threads:[~2026-07-30 11:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 11:20 [PATCH v4] crypto: rsassa-pkcs1 - Avoid cacheline sharing with underlying driver Changwei Zou
2026-07-30 11:35 ` Lukas Wunner [this message]
2026-07-30 12:06   ` Changwei Zou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ams3ED05SiobrDap@wunner.de \
    --to=lukas@wunner.de \
    --cc=Martin.Kepplinger-Novakovic@ginzinger.com \
    --cc=changwei.zou@canonical.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=ignat@linux.win \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martink@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox