From: Herbert Xu <herbert@gondor.apana.org.au>
To: Guangshuo Li <lgs201920130244@gmail.com>
Cc: Gilad Ben-Yossef <gilad@benyossef.com>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] crypto: ccree: fix autosuspend cleanup during teardown
Date: Sat, 15 Aug 2026 11:20:32 +1000 [thread overview]
Message-ID: <an--4DCWClWpPJwB@gondor.apana.org.au> (raw)
In-Reply-To: <20260808091734.2727295-1-lgs201920130244@gmail.com>
On Sat, Aug 08, 2026 at 05:17:34PM +0800, Guangshuo Li wrote:
>
> diff --git a/drivers/crypto/ccree/cc_driver.c b/drivers/crypto/ccree/cc_driver.c
> index 061e68a31c36..b127ec64a087 100644
> --- a/drivers/crypto/ccree/cc_driver.c
> +++ b/drivers/crypto/ccree/cc_driver.c
> @@ -567,6 +567,7 @@ static int init_cc_resources(struct platform_device *plat_dev)
> post_regs_err:
> fini_cc_regs(new_drvdata);
> post_pm_err:
> + pm_runtime_dont_use_autosuspend(dev);
> pm_runtime_put_noidle(dev);
> pm_runtime_disable(dev);
> pm_runtime_set_suspended(dev);
Sashiko is asking about the order of these pm_runtime calls, could
you please investigate?
https://sashiko.dev/#/patchset/20260808091734.2727295-1-lgs201920130244%40gmail.com
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2026-08-15 1:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-08 9:17 [PATCH] crypto: ccree: fix autosuspend cleanup during teardown Guangshuo Li
2026-08-15 1:20 ` Herbert Xu [this message]
2026-08-20 14:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an--4DCWClWpPJwB@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=gilad@benyossef.com \
--cc=lgs201920130244@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox