Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, kadlec@netfilter.org,
	fw@strlen.de, linux-crypto@vger.kernel.org
Subject: Re: [PATCH nf-next v4 01/13] rhashtable: add rhashtable_flush_and_free helper
Date: Tue, 8 Sep 2026 15:12:27 +1000	[thread overview]
Message-ID: <ap-ZOyOS6j_K5gmZ@gondor.apana.org.au> (raw)
In-Reply-To: <20260904185321.30313-2-fw@strlen.de>

Florian Westphal <fw@strlen.de> wrote:
> Will be used by upcoming ipset rhashtable conversion.
> 
> "walk rht with unlink+free" triggers LLM reject pattern:
> "possible softirq CPU stall".
> 
> "walk rht with unlink+free + cond_resched" triggers
> "possibly skipped elements".
> 
> Add a helper to detach current hash backend storage from the
> rhashtable, then iterate and flush all contained elements.
> 
> Cc: herbert@gondor.apana.org.au
> Cc: linux-crypto@vger.kernel.org
> Link: https://sashiko.dev/#/patchset/20260828152256.8759-1-fw%40strlen.de
> Assisted-by: Claude:claude-sonnet-5
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> Herbert: If you prefer to take this via the crypto tree, please
> let me know.
> Otherwise, an explicit Ack would be appreciated, so this can
> be handled via nf-next.  Thanks.
> 
> net/ipv6/ila/ could be converted to use this helper too.
> 
> include/linux/rhashtable.h |  19 ++++++
> lib/rhashtable.c           | 127 +++++++++++++++++++++++++++++++++++++
> 2 files changed, 146 insertions(+)

Sorry I wasn't paying attention.

So is the problem that there is no way to remove all elements for
a given key in an rhltable?

If that is what's needed then we should just add it for rhltable
since normal rhashtable's do not contain duplicate objects for a
given key.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  parent reply	other threads:[~2026-09-08  5:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260904185321.30313-1-fw@strlen.de>
2026-09-04 18:53 ` [PATCH nf-next v4 01/13] rhashtable: add rhashtable_flush_and_free helper Florian Westphal
2026-09-04 19:29   ` Florian Westphal
2026-09-08  5:12   ` Herbert Xu [this message]
2026-09-08  5:30     ` Florian Westphal
2026-09-08  9:04       ` Herbert Xu
2026-09-08  9:56         ` Florian Westphal
2026-09-08 12:39           ` Herbert Xu
2026-09-08 13:25             ` Florian Westphal
2026-09-09  3:49               ` Herbert Xu
2026-09-09  4:17   ` Herbert Xu
2026-09-09 14:45     ` Florian Westphal
2026-09-10  9:11       ` Herbert Xu
2026-09-10 10:41         ` Florian Westphal
2026-09-11 11:56           ` Herbert Xu
2026-09-11 12:54             ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ap-ZOyOS6j_K5gmZ@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=fw@strlen.de \
    --cc=kadlec@netfilter.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox